Skip to content

Commit fa79325

Browse files
BAL export enhanced for more objects and subobject (#66)
* BAL export enhanced for more objects and subobject * abaplint fixes
1 parent 8e6c5bd commit fa79325

11 files changed

+122
-108
lines changed

abaplint.json

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@
2323
"exclude": [],
2424
"reason": ""
2525
},
26-
"abapdoc": {
27-
"exclude": [],
28-
"reason": "",
29-
"checkLocal": false
30-
},
3126
"allowed_object_naming": {
3227
"exclude": [],
3328
"reason": ""
@@ -51,7 +46,7 @@
5146
"communication": true,
5247
"statics": true,
5348
"systemCall": true,
54-
"defaultKey": true,
49+
"defaultKey": false,
5550
"break": true
5651
},
5752
"begin_end_names": {
@@ -86,16 +81,6 @@
8681
"exclude": [],
8782
"reason": ""
8883
},
89-
"class_attribute_names": {
90-
"exclude": [],
91-
"reason": "",
92-
"patternKind": "required",
93-
"ignoreNames": [],
94-
"ignorePatterns": [],
95-
"ignoreExceptions": true,
96-
"statics": "^G._.+$",
97-
"instance": "^M._.+$"
98-
},
9984
"cloud_types": {
10085
"exclude": [],
10186
"reason": ""
@@ -196,10 +181,6 @@
196181
"exclude": [],
197182
"reason": ""
198183
},
199-
"implement_methods": {
200-
"exclude": [],
201-
"reason": ""
202-
},
203184
"in_statement_indentation": {
204185
"exclude": [],
205186
"reason": "",
@@ -369,7 +350,7 @@
369350
"prefix_is_current_class": {
370351
"exclude": [],
371352
"reason": "",
372-
"omitMeInstanceCalls": true
353+
"omitMeInstanceCalls": false
373354
},
374355
"release_idoc": {
375356
"exclude": [],
@@ -459,10 +440,6 @@
459440
"exclude": [],
460441
"reason": ""
461442
},
462-
"unused_variables": {
463-
"exclude": [],
464-
"reason": ""
465-
},
466443
"use_new": {
467444
"exclude": [],
468445
"reason": ""

src/zale_export_log_bal.prog.abap

Lines changed: 25 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@
55
*&---------------------------------------------------------------------*
66
REPORT zale_export_log_bal.
77

8+
TABLES balhdr.
9+
810
PARAMETERS scenario TYPE zale_config-ale_scenario OBLIGATORY.
9-
PARAMETERS object TYPE balhdr-object OBLIGATORY.
10-
PARAMETERS suobject TYPE balhdr-subobject OBLIGATORY.
11-
PARAMETERS fromdat TYPE dats OBLIGATORY.
12-
PARAMETERS fromtim TYPE tims OBLIGATORY.
13-
PARAMETERS todat TYPE dats OBLIGATORY.
14-
PARAMETERS totim TYPE tims OBLIGATORY.
11+
SELECT-OPTIONS object FOR balhdr-object.
12+
SELECT-OPTIONS suobject FOR balhdr-subobject.
13+
PARAMETERS lastsec TYPE i.
14+
PARAMETERS fromdat TYPE dats.
15+
PARAMETERS fromtim TYPE tims.
16+
PARAMETERS todat TYPE dats.
17+
PARAMETERS totim TYPE tims.
1518
PARAMETERS test TYPE flag DEFAULT 'X'.
1619

1720
INITIALIZATION.
@@ -25,12 +28,22 @@ START-OF-SELECTION.
2528

2629
DATA filter_values TYPE zif_ale_log_reader=>ty_filter_values.
2730

28-
filter_values = VALUE #( ( key = 'OBJECT' value = object )
29-
( key = 'SUBOBJECT' value = suobject )
30-
( key = 'DATE_FROM' value = fromdat )
31-
( key = 'TIME_FROM' value = fromtim )
32-
( key = 'DATE_TO' value = todat )
33-
( key = 'TIME_TO' value = totim ) ).
31+
32+
IF lastsec IS NOT INITIAL.
33+
fromdat = sy-datum.
34+
fromtim = sy-uzeit - lastsec.
35+
todat = sy-datum.
36+
totim = sy-uzeit.
37+
ENDIF.
38+
39+
40+
filter_values = VALUE #( ( key = 'OBJECT' value = REF #( object[] ) )
41+
( key = 'SUBOBJECT' value = REF #( suobject[] ) )
42+
( key = 'LAST_SECONDS' value = REF #( lastsec ) )
43+
( key = 'DATE_FROM' value = REF #( fromdat ) )
44+
( key = 'TIME_FROM' value = REF #( fromtim ) )
45+
( key = 'DATE_TO' value = REF #( todat ) )
46+
( key = 'TIME_TO' value = REF #( totim ) ) ).
3447

3548
"set customzing
3649
DATA(customizing) = NEW zcl_ale_customizing_base( scenario ).

src/zale_export_log_bal.prog.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@
2727
<ENTRY>from time</ENTRY>
2828
<LENGTH>17</LENGTH>
2929
</item>
30+
<item>
31+
<ID>S</ID>
32+
<KEY>LASTSEC</KEY>
33+
<ENTRY>search last in seconds</ENTRY>
34+
<LENGTH>30</LENGTH>
35+
</item>
3036
<item>
3137
<ID>S</ID>
3238
<KEY>OBJECT</KEY>

src/zcl_ale_customizing.clas.abap

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ CLASS zcl_ale_customizing IMPLEMENTATION.
4040
me->scenario = scenario.
4141

4242
SELECT *
43-
FROM zale_config
44-
INTO TABLE @configurations
45-
WHERE ale_scenario = @scenario.
43+
FROM zale_config
44+
INTO TABLE @configurations
45+
WHERE ale_scenario = @scenario.
4646

4747
ENDMETHOD.
4848

src/zcl_ale_log_connector_gelf.clas.abap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ ENDCLASS.
1616
CLASS zcl_ale_log_connector_gelf IMPLEMENTATION.
1717
METHOD zif_ale_log_connector~connect.
1818

19+
DATA xjson TYPE xstring.
20+
DATA text TYPE string.
21+
1922
DATA(gelf_url) = customizing->get_connector_url( ).
2023

2124
LOOP AT converted_logs ASSIGNING FIELD-SYMBOL(<converted_log>).
@@ -37,9 +40,6 @@ CLASS zcl_ale_log_connector_gelf IMPLEMENTATION.
3740
client->request->set_method( 'POST' ).
3841
client->request->set_content_type( 'application/json' ).
3942

40-
DATA xjson TYPE xstring.
41-
DATA text TYPE string.
42-
4343
text = <converted_log>-json.
4444

4545
CALL FUNCTION 'SCMS_STRING_TO_XSTRING'
@@ -88,4 +88,4 @@ CLASS zcl_ale_log_connector_gelf IMPLEMENTATION.
8888

8989
ENDMETHOD.
9090

91-
ENDCLASS.
91+
ENDCLASS.

src/zcl_ale_log_connector_loki.clas.abap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ENDCLASS.
1515

1616
CLASS zcl_ale_log_connector_loki IMPLEMENTATION.
1717
METHOD zif_ale_log_connector~connect.
18-
18+
sy-subrc = sy-subrc. "placeholder
1919
ENDMETHOD.
2020

21-
ENDCLASS.
21+
ENDCLASS.

src/zcl_ale_log_converter_loki.clas.abap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ENDCLASS.
1515

1616
CLASS zcl_ale_log_converter_loki IMPLEMENTATION.
1717
METHOD zif_ale_log_converter~convert.
18-
18+
sy-subrc = sy-subrc. "placeholder
1919
ENDMETHOD.
2020

2121
ENDCLASS.

src/zcl_ale_log_reader_bal.clas.abap

Lines changed: 73 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -20,57 +20,82 @@ CLASS zcl_ale_log_reader_bal IMPLEMENTATION.
2020
DATA message_parameters TYPE STANDARD TABLE OF balmp.
2121
DATA contexts TYPE STANDARD TABLE OF balc.
2222
DATA exceptions TYPE STANDARD TABLE OF bal_s_exception.
23+
DATA log_entry TYPE string.
2324

25+
FIELD-SYMBOLS <object_range> TYPE STANDARD TABLE.
26+
FIELD-SYMBOLS <subobject_range> TYPE STANDARD TABLE.
2427

25-
DATA(object) = VALUE balobj_d( filter_values[ key = 'OBJECT' ]-value ).
26-
DATA(subobject) = VALUE balsubobj( filter_values[ key = 'SUBOBJECT' ]-value ).
27-
DATA(date_from) = VALUE baldate( filter_values[ key = 'DATE_FROM' ]-value ).
28-
DATA(time_from) = VALUE baltime( filter_values[ key = 'TIME_FROM' ]-value ).
29-
DATA(date_to) = VALUE baldate( filter_values[ key = 'DATE_TO' ]-value ).
30-
DATA(time_to) = VALUE baltime( filter_values[ key = 'TIME_TO' ]-value ).
31-
32-
33-
CALL FUNCTION 'APPL_LOG_READ_DB'
34-
EXPORTING
35-
object = object
36-
subobject = subobject
37-
* external_number = space " external number
38-
date_from = date_from
39-
date_to = date_to
40-
time_from = time_from
41-
time_to = time_to
42-
* log_class = '4' " Problem class
43-
* program_name = '*' " Program name
44-
* transaction_code = '*' " Transaction name
45-
* user_id = space " User name
46-
* mode = '+' " Operating mode
47-
* put_into_memory = space
48-
* IMPORTING
49-
* number_of_logs = " Number of logs read
50-
TABLES
51-
header_data = header_data
52-
header_parameters = header_parameters
53-
messages = messages
54-
message_parameters = message_parameters
55-
contexts = contexts
56-
t_exceptions = exceptions.
57-
58-
DATA log_entry TYPE string.
59-
LOOP AT header_data ASSIGNING FIELD-SYMBOL(<header_data>).
60-
LOOP AT messages ASSIGNING FIELD-SYMBOL(<message>) WHERE lognumber = <header_data>-lognumber.
61-
62-
MESSAGE ID <message>-msgid TYPE <message>-msgty NUMBER <message>-msgno
63-
WITH <message>-msgv1 <message>-msgv2 <message>-msgv3 <message>-msgv4
64-
INTO log_entry.
65-
66-
DATA(additional_fields) = VALUE zif_ale_log_reader=>ty_additional_fields( ( field = 'object' value = <header_data>-object )
67-
( field = 'subobject' value = <header_data>-subobject ) ).
68-
69-
logs = VALUE #( BASE logs ( level = <message>-msgty
70-
header_text = |{ <header_data>-extnumber } / { <header_data>-object } / { <header_data>-subobject }|
71-
item_text = log_entry
72-
additional_fields = additional_fields ) ).
28+
DATA(object_ref) = filter_values[ key = 'OBJECT' ]-value.
29+
ASSIGN object_ref->* TO <object_range>.
30+
31+
DATA(subobject_ref) = filter_values[ key = 'SUBOBJECT' ]-value.
32+
ASSIGN subobject_ref->* TO <subobject_range>.
33+
34+
SELECT
35+
object,
36+
subobject
37+
FROM balsub
38+
INTO TABLE @DATA(objects)
39+
WHERE object IN @<object_range>
40+
AND subobject IN @<subobject_range>.
41+
42+
43+
DATA(date_from_ref) = filter_values[ key = 'DATE_FROM' ]-value.
44+
ASSIGN date_from_ref->* TO FIELD-SYMBOL(<date_from>).
45+
46+
DATA(time_from_ref) = filter_values[ key = 'TIME_FROM' ]-value.
47+
ASSIGN time_from_ref->* TO FIELD-SYMBOL(<time_from>).
7348

49+
DATA(date_to_ref) = filter_values[ key = 'DATE_TO' ]-value.
50+
ASSIGN date_to_ref->* TO FIELD-SYMBOL(<date_to>).
51+
52+
DATA(time_to_ref) = filter_values[ key = 'TIME_TO' ]-value.
53+
ASSIGN time_to_ref->* TO FIELD-SYMBOL(<time_to>).
54+
55+
56+
LOOP AT objects ASSIGNING FIELD-SYMBOL(<object>).
57+
58+
CALL FUNCTION 'APPL_LOG_READ_DB'
59+
EXPORTING
60+
object = <object>-object
61+
subobject = <object>-subobject
62+
* external_number = space " external number
63+
date_from = CONV baldate( <date_from> )
64+
date_to = CONV baldate( <date_to> )
65+
time_from = CONV baltime( <time_from> )
66+
time_to = CONV baltime( <time_to> )
67+
* log_class = '4' " Problem class
68+
* program_name = '*' " Program name
69+
* transaction_code = '*' " Transaction name
70+
* user_id = space " User name
71+
* mode = '+' " Operating mode
72+
* put_into_memory = space
73+
* IMPORTING
74+
* number_of_logs = " Number of logs read
75+
TABLES
76+
header_data = header_data
77+
header_parameters = header_parameters
78+
messages = messages
79+
message_parameters = message_parameters
80+
contexts = contexts
81+
t_exceptions = exceptions.
82+
83+
LOOP AT header_data ASSIGNING FIELD-SYMBOL(<header_data>).
84+
LOOP AT messages ASSIGNING FIELD-SYMBOL(<message>) WHERE lognumber = <header_data>-lognumber.
85+
86+
MESSAGE ID <message>-msgid TYPE <message>-msgty NUMBER <message>-msgno
87+
WITH <message>-msgv1 <message>-msgv2 <message>-msgv3 <message>-msgv4
88+
INTO log_entry.
89+
90+
DATA(additional_fields) = VALUE zif_ale_log_reader=>ty_additional_fields( ( field = 'object' value = <header_data>-object )
91+
( field = 'subobject' value = <header_data>-subobject ) ).
92+
93+
logs = VALUE #( BASE logs ( level = <message>-msgty
94+
header_text = |{ <header_data>-extnumber } / { <header_data>-object } / { <header_data>-subobject }|
95+
item_text = log_entry
96+
additional_fields = additional_fields ) ).
97+
98+
ENDLOOP.
7499
ENDLOOP.
75100
ENDLOOP.
76101

src/zcl_ale_log_reader_sm21.clas.abap

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,8 @@ CLASS zcl_ale_log_reader_sm21 IMPLEMENTATION.
2626

2727
syslog_filter = NEW #( ).
2828

29-
syslog_filter->set_filter_datetime(
30-
EXPORTING
31-
im_datetime_from = datetime_from " UTC Time Stamp in Short Form (YYYYMMDDhhmmss)
32-
im_datetime_to = datetime_to " UTC Time Stamp in Short Form (YYYYMMDDhhmmss)
33-
).
29+
syslog_filter->set_filter_datetime( im_datetime_from = datetime_from
30+
im_datetime_to = datetime_to ).
3431

3532
DATA(syslog_client) = NEW cl_syslog_sapcontrol_client( ).
3633

@@ -49,7 +46,6 @@ CLASS zcl_ale_log_reader_sm21 IMPLEMENTATION.
4946
ENDTRY.
5047
ENDLOOP.
5148

52-
5349
LOOP AT syslogs_total ASSIGNING FIELD-SYMBOL(<syslog>).
5450

5551
logs = VALUE #( BASE logs ( level = '1'
@@ -58,9 +54,6 @@ CLASS zcl_ale_log_reader_sm21 IMPLEMENTATION.
5854

5955
ENDLOOP.
6056

61-
62-
63-
6457
ENDMETHOD.
6558

66-
ENDCLASS.
59+
ENDCLASS.

src/zcl_ale_log_reader_smicm.clas.abap

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ ENDCLASS.
1515

1616
CLASS zcl_ale_log_reader_smicm IMPLEMENTATION.
1717
METHOD zif_ale_log_reader~read.
18-
18+
sy-subrc = sy-subrc. "placeholder
1919
ENDMETHOD.
2020

21-
ENDCLASS.
21+
ENDCLASS.

0 commit comments

Comments
 (0)