Skip to content

Commit a7bf232

Browse files
committed
fix: add override keyword to Lit component lifecycle methods
Add the TypeScript `override` keyword to all Lit component methods that override parent class methods. This is required for Google's internal repository compilation. Methods updated: - render() - connectedCallback() - disconnectedCallback() - firstUpdated() - willUpdate() Fixes google#463
1 parent 21c6d27 commit a7bf232

9 files changed

Lines changed: 20 additions & 20 deletions

File tree

samples/client/lit/contact/ui/snackbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export class Snackbar extends LitElement {
215215
});
216216
}
217217

218-
render() {
218+
override render() {
219219
let rotate = false;
220220
let icon = "";
221221
for (let i = this.#messages.length - 1; i >= 0; i--) {

samples/client/lit/shell/ui/snackbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export class Snackbar extends LitElement {
215215
});
216216
}
217217

218-
render() {
218+
override render() {
219219
let rotate = false;
220220
let icon = "";
221221
for (let i = this.#messages.length - 1; i >= 0; i--) {

samples/personalized_learning/src/flashcard.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export class Flashcard extends LitElement {
222222
this._flipped = !this._flipped;
223223
}
224224

225-
render() {
225+
override render() {
226226
const frontText = this.resolveStringValue(this.front);
227227
const backText = this.resolveStringValue(this.back);
228228
const categoryText = this.resolveStringValue(this.category);

samples/personalized_learning/src/quiz-card.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ export class QuizCard extends LitElement {
269269
return selected?.isCorrect ?? false;
270270
}
271271

272-
render() {
272+
override render() {
273273
const questionText = this.resolveStringValue(this.question);
274274
const categoryText = this.resolveStringValue(this.category);
275275
const explanationText = this.resolveStringValue(this.explanation);

tools/editor/ui/drawable-canvas.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -200,12 +200,12 @@ export class DrawableCanvas extends LitElement {
200200
(localStorage.getItem("drawable-mode") as RenderMode) ?? "free";
201201
}
202202

203-
connectedCallback(): void {
203+
override connectedCallback(): void {
204204
super.connectedCallback();
205205
this.#resizeObserver.observe(this);
206206
}
207207

208-
disconnectedCallback(): void {
208+
override disconnectedCallback(): void {
209209
super.disconnectedCallback();
210210
this.#resizeObserver.disconnect();
211211
}
@@ -347,7 +347,7 @@ export class DrawableCanvas extends LitElement {
347347
}
348348
}
349349

350-
render() {
350+
override render() {
351351
return html`${svg`
352352
<svg
353353
viewBox="${this.#adjustment.x} ${this.#adjustment.y} ${this.#bounds.width

tools/editor/ui/item-select.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ export class ItemSelect extends LitElement {
290290
this.requestUpdate();
291291
}
292292

293-
protected firstUpdated(): void {
293+
protected override firstUpdated(): void {
294294
if (!this.autoActivate) {
295295
return;
296296
}
@@ -304,7 +304,7 @@ export class ItemSelect extends LitElement {
304304
});
305305
}
306306

307-
render() {
307+
override render() {
308308
const idx = this.freezeValue !== -1 ? this.freezeValue : this.#selected;
309309
const renderedValue = this.#values[idx] ?? {
310310
title: "No items available",

tools/editor/ui/splitter.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@ export class Splitter extends LitElement {
118118
this.#setAndStore();
119119
});
120120

121-
connectedCallback(): void {
121+
override connectedCallback(): void {
122122
super.connectedCallback();
123123

124124
this.#resizeObserver.observe(this);
125125
}
126126

127-
disconnectedCallback(): void {
127+
override disconnectedCallback(): void {
128128
super.disconnectedCallback();
129129

130130
this.#resizeObserver.disconnect();
@@ -238,7 +238,7 @@ export class Splitter extends LitElement {
238238
return value;
239239
}
240240

241-
firstUpdated() {
241+
override firstUpdated() {
242242
if (!this.name) {
243243
console.warn("Splitter has no name; it won't have any values stored.");
244244
return;
@@ -337,7 +337,7 @@ export class Splitter extends LitElement {
337337
}
338338
}
339339

340-
protected willUpdate(
340+
protected override willUpdate(
341341
changedProperties:
342342
| PropertyValueMap<{ direction: Direction }>
343343
| Map<PropertyKey, unknown>
@@ -349,7 +349,7 @@ export class Splitter extends LitElement {
349349
this.#updateStyles();
350350
}
351351

352-
render() {
352+
override render() {
353353
return html`${this.split.map((_, idx) => {
354354
const handle =
355355
idx < this.split.length - 1

tools/inspector/ui/snackbar.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ export class Snackbar extends LitElement {
216216
});
217217
}
218218

219-
render() {
219+
override render() {
220220
let rotate = false;
221221
let icon = "";
222222
for (let i = this.#messages.length - 1; i >= 0; i--) {

tools/inspector/ui/splitter.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -118,13 +118,13 @@ export class Splitter extends LitElement {
118118
this.#setAndStore();
119119
});
120120

121-
connectedCallback(): void {
121+
override connectedCallback(): void {
122122
super.connectedCallback();
123123

124124
this.#resizeObserver.observe(this);
125125
}
126126

127-
disconnectedCallback(): void {
127+
override disconnectedCallback(): void {
128128
super.disconnectedCallback();
129129

130130
this.#resizeObserver.disconnect();
@@ -238,7 +238,7 @@ export class Splitter extends LitElement {
238238
return value;
239239
}
240240

241-
firstUpdated() {
241+
override firstUpdated() {
242242
if (!this.name) {
243243
console.warn("Splitter has no name; it won't have any values stored.");
244244
return;
@@ -337,7 +337,7 @@ export class Splitter extends LitElement {
337337
}
338338
}
339339

340-
protected willUpdate(
340+
protected override willUpdate(
341341
changedProperties:
342342
| PropertyValueMap<{ direction: Direction }>
343343
| Map<PropertyKey, unknown>
@@ -349,7 +349,7 @@ export class Splitter extends LitElement {
349349
this.#updateStyles();
350350
}
351351

352-
render() {
352+
override render() {
353353
return html`${this.split.map((_, idx) => {
354354
const handle =
355355
idx < this.split.length - 1

0 commit comments

Comments
 (0)