Fix migration remove dead code

Author: ZsoltMolnarrr

common/src/main/java/net/spell_power/SpellPowerMod.java

@@ -156,7 +156,10 @@ public static AttributesConfig.AttributeScope attributeScope() {
     }
 
     public static void migrateAttributes(ServerPlayerEntity player) {
-        var attributes = List.of(SpellSchools.GENERIC.attributeEntry);
+        var attributes = SpellSchools.all().stream()
+                .filter(school -> school.isMagicArchetype() && school.ownsAttribute())
+                .map(school -> school.attributeEntry)
+                .toList();
         for (var attribute: attributes) {
             if (attribute == null) {
                 continue;

common/src/main/java/net/spell_power/api/SpellSchool.java

@@ -65,8 +65,6 @@ public enum Archetype { ARCHERY, MAGIC, MELEE }
     @Nullable public RegistryEntry<EntityAttribute> attributeEntry;
     @Nullable public RegistryEntry<Potion> potionEntry;
 
-    public float innateBonus = 0;
-
     public SpellSchool(Archetype archetype, Identifier id, int color, RegistryKey<DamageType> damageType, RegistryEntry<EntityAttribute> attributeEntry) {
         this(archetype, id, color, damageType, null, null);
         this.attributeEntry = attributeEntry;
@@ -79,30 +77,6 @@ public SpellSchool(Archetype archetype, Identifier id, int color, RegistryKey<Da
         this.damageType = damageType;
         this.ownedAttribute = attribute;
         this.ownedBoostEffect = boostEffect;
-        this.innateBonus = SpellPowerMod.attributesConfig.safeValue().base_spell_power;
-    }
-
-    public SpellSchool innateModifier(float value) {
-        this.innateBonus = 0F;
-        return this;
-    }
-
-    public boolean hasInnateModifier() {
-        return innateBonus >= 0F;
-    }
-
-    private Supplier<EntityAttributeModifier> innateModifier = Suppliers.memoize(() ->
-            new EntityAttributeModifier(
-                    ModifierDefinitions.INNATE_BONUS,
-                    this.getInnateBonus(),
-                    EntityAttributeModifier.Operation.ADD_VALUE
-            )
-    );
-    private float getInnateBonus() {
-        return innateBonus;
-    }
-    public EntityAttributeModifier getInnateModifier() {
-        return innateModifier.get();
     }
 
     public float attributeBaseValue() {
@@ -134,6 +108,10 @@ public boolean ownsAttribute() {
         return ownedAttribute != null;
     }
 
+    public boolean isMagicArchetype() {
+        return archetype == Archetype.MAGIC;
+    }
+
     // Sources
     public enum Apply { ADD, MULTIPLY }
     public record QueryArgs(LivingEntity entity) { }