Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frozen_atom is buggy in current version #33

Open
ms860309 opened this issue Jun 4, 2021 · 0 comments
Open

Frozen_atom is buggy in current version #33

ms860309 opened this issue Jun 4, 2021 · 0 comments

Comments

@ms860309
Copy link
Contributor

ms860309 commented Jun 4, 2021

Hi,
The older version of pyGSM treats the frozen atom and its gradient in pygsm/coordinate_systems/internal_coordinates.py.
But now is in pygsm/level_of_theories/base_lot.py

def get_gradient(self,coords,multiplicity,state,frozen_atoms=None):
	if self.hasRanForCurrentCoords==False or (coords != self.currentCoords).any():
		self.currentCoords = coords.copy()
		geom = manage_xyz.np_to_xyz(self.geom,self.currentCoords)
		self.runall(geom)
	Gradient = self.Gradients[(multiplicity,state)]
	if Gradient.value is not None:
		if frozen_atoms is not None:
			for a in frozen_atoms:
				Gradient.value[a,:]=0.

This change seems to make node can not converge while using frozen atoms.
image

Jianyi

ms860309 added a commit to ms860309/pyGSM that referenced this issue Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant