Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow up on dppe example #80

Open
5 tasks
Tracked by #5
joshkamm opened this issue May 17, 2024 · 0 comments
Open
5 tasks
Tracked by #5

follow up on dppe example #80

joshkamm opened this issue May 17, 2024 · 0 comments
Assignees

Comments

@joshkamm
Copy link
Member

joshkamm commented May 17, 2024

One thing that could be a bit difficult for a new user is defining the functional group factory. One possible approach could be to attach a unique atom to the atom you want to bind to the metal (e.g At) and I could use that to require less python tinkering for the user.

  • In bidentate it becomes important to check whether the ancillary ligand has successfully bound to the metal because in some conformers this may not be possible -> I think this would best be checked and filtered in between the metal optimizer step and the xTB step using the functionality that checks how many bonds are different between intended and reperceived optimized structure
  • Try a different example (like eliminating two methyl groups with dppe) and log everything that needs to be changed so collaborators can try their own ligands.
  • Pass test if a certain number of conformers optimize successfully with pyGSM
  • Error handling (probably want to catch exceptions inside function that the parallel pool calls so individual errors don't break all conformers)
  • How do you programmatically determine if you're running in a codespace or github action and the number of CPUs
@joshkamm joshkamm mentioned this issue May 17, 2024
73 tasks
@joshkamm joshkamm self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant