Skip to content

Conversation

@conradoplg
Copy link
Contributor

@conradoplg conradoplg commented Oct 29, 2024

...to take SigningCommitments and not depend on serialization feature.

This reflects the current state of zcash/zips#895

I created as a draft because it's probably better to wait for that to finish being reviewed and merged.

I ran the tests with reddsa.

…tments and not depend on serialization feature
@conradoplg conradoplg force-pushed the change-randomizer-generation branch from a99ec60 to ab8e2ef Compare October 29, 2024 23:09
@conradoplg conradoplg marked this pull request as ready for review January 13, 2026 14:56
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 77.31%. Comparing base (504ef20) to head (c7c3295).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
frost-rerandomized/src/lib.rs 98.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   77.45%   77.31%   -0.15%     
==========================================
  Files          41       41              
  Lines        4503     4566      +63     
==========================================
+ Hits         3488     3530      +42     
- Misses       1015     1036      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mergify mergify bot added the queued label Jan 23, 2026
@mergify
Copy link
Contributor

mergify bot commented Jan 23, 2026

Merge Queue Status

✅ The pull request has been merged at c7c3295

This pull request spent 3 minutes 45 seconds in the queue, including 6 seconds running CI.
The checks were run on draft #992.

Required conditions to merge

mergify bot added a commit that referenced this pull request Jan 23, 2026
@mergify mergify bot merged commit bac3297 into main Jan 23, 2026
23 checks passed
@mergify mergify bot deleted the change-randomizer-generation branch January 23, 2026 14:33
@mergify mergify bot removed the queued label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants