-
Notifications
You must be signed in to change notification settings - Fork 87
frost-rerandomized: change Randomizer generation #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tments and not depend on serialization feature
a99ec60 to
ab8e2ef
Compare
…change-randomizer-generation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 77.45% 77.31% -0.15%
==========================================
Files 41 41
Lines 4503 4566 +63
==========================================
+ Hits 3488 3530 +42
- Misses 1015 1036 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
natalieesk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Merge Queue Status✅ The pull request has been merged at c7c3295 This pull request spent 3 minutes 45 seconds in the queue, including 6 seconds running CI. Required conditions to merge
|
...to take SigningCommitments and not depend on serialization feature.
This reflects the current state of zcash/zips#895
I created as a draft because it's probably better to wait for that to finish being reviewed and merged.
I ran the tests with
reddsa.