Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle application whose .desktop doesn't exist #2

Open
Zaedus opened this issue Aug 15, 2024 · 1 comment
Open

Handle application whose .desktop doesn't exist #2

Zaedus opened this issue Aug 15, 2024 · 1 comment

Comments

@Zaedus
Copy link
Owner

Zaedus commented Aug 15, 2024

An error is thrown when attempting to delete a web app whose .desktop doesn't exist anymore (for whatever reason). Additionally, if the desktop file doesn't exist, getting the app's icon is impossible, meaning the AppRow fails to load, meaning the the AppPage can't be shown, meaning no deletion. Do not ask how I managed to even attempt deletion given this fact...

There should be a default icon if we cannot load the actual icon, and deletion should probably check if the file exists before attempting an uninstall.

@Zaedus
Copy link
Owner Author

Zaedus commented Sep 5, 2024

To follow up on this issue: When I uninstall the app (but keep the data) and then reinstall, everything is fine except all the desktop files have been removed. Having some kind of "doctor" dialog that warns you of the problem and gives the user a button which will fix it would be ideal since each desktop file requires user confirmation, and I'd imagine most would be confused at the unexplained multitude of prompts if it automatically went ahead and fixed it.

For those encountering this problem, the easiest way to get your launcher/.desktop file back is to change the name or icon since those require reinstalling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant