animateCamera with target increases the zoomLevel to maximum in iOS #215

Author: EddyVerbruggen

.travis.yml

@@ -8,14 +8,17 @@ android:
     - sys-img-armeabi-v7a-android-21
 
 before_cache:
-    - rm -f $HOME/.gradle/caches/modules-2/modules-2.lock 
+    - rm -f $HOME/.gradle/caches/modules-2/modules-2.lock
 
 cache:
     directories:
         - .nvm
         - $HOME/.gradle/caches/
         - $HOME/.gradle/wrapper/
 
+before_install:
+  - yes | sdkmanager "platforms;android-26"
+
 install:
     - echo no | npm install -g nativescript
     - tns usage-reporting disable
@@ -33,13 +36,13 @@ matrix:
       language: node_js
       os: linux
       node_js: "6"
-      script: "npm run ci.tslint" 
+      script: "npm run ci.tslint"
     - stage: "WebPack"
       os: osx
       env:
         - Webpack="iOS"
       osx_image: xcode8.3
-      language: node_js 
+      language: node_js
       node_js: "6"
       jdk: oraclejdk8
       before_install:
@@ -54,7 +57,7 @@ matrix:
       before_install: nvm install 6.10.3
       script: cd ../demo &&  tns build android --bundle
     - stage: "Build"
-      env: 
+      env:
         - BuildAndroid="25"
       language: android
       os: linux
@@ -63,16 +66,15 @@ matrix:
       script:
         - cd ../demo && tns build android
     - os: osx
-      env: 
+      env:
         - BuildiOS="10.3"
         - Xcode="8.3"
       osx_image: xcode8.3
-      language: node_js 
+      language: node_js
       node_js: "6"
       jdk: oraclejdk8
       before_install:
         - gem install cocoapods
         - pod repo update
       script:
         - cd ../demo && tns build ios
-    

CHANGELOG.md

@@ -3,12 +3,16 @@
 ## [4.0.0](https://github.com/EddyVerbruggen/nativescript-mapbox/tree/4.0.0) (2018-05-07)
 [Full Changelog](https://github.com/EddyVerbruggen/nativescript-mapbox/compare/3.3.0...4.0.0)
 
+**Fixed bugs:**
+
+- The App crashs on Android when using nativescript-vue - missing toHumanReadableAscii method[\#216](https://github.com/EddyVerbruggen/nativescript-mapbox/issues/216)
+
 **Implemented enhancements:**
 
 - Polygons for iOS [\#204](https://github.com/EddyVerbruggen/nativescript-mapbox/issues/204)
+- animateCamera with target increases the zoomLevel to maximum in iOS [\#215](https://github.com/EddyVerbruggen/nativescript-mapbox/issues/215)
 - Bump Mapbox iOS SDK to 4.0.0 and Android to 6.0.1 [\#219](https://github.com/EddyVerbruggen/nativescript-mapbox/issues/219)
 
-
 ## [3.3.0](https://github.com/EddyVerbruggen/nativescript-mapbox/tree/3.3.0) (2018-01-20)
 [Full Changelog](https://github.com/EddyVerbruggen/nativescript-mapbox/compare/3.2.0...3.3.0)
 

demo/app/main-view-model.ts

@@ -450,7 +450,7 @@ export class HelloWorldModel extends Observable {
           altitude: 500, // iOS
           bearing: 270,
           tilt: 50,
-          duration: 10000
+          duration: 7000
         }
     ).then(
         result => {

src/mapbox.android.ts

@@ -193,7 +193,8 @@ const _showLocation = (theMapView, mapboxMap) => {
   }
 
   const locationLayerPlugin = new com.mapbox.mapboxsdk.plugins.locationlayer.LocationLayerPlugin(theMapView, mapboxMap, _locationEngine);
-  locationLayerPlugin.setCameraMode(com.mapbox.mapboxsdk.plugins.locationlayer.modes.CameraMode.TRACKING);
+  // with the foloowing line enabled, the camera moves to the user's location once it's determined
+  // locationLayerPlugin.setCameraMode(com.mapbox.mapboxsdk.plugins.locationlayer.modes.CameraMode.TRACKING);
 };
 
 const _getClickedMarkerDetails = (clicked) => {
@@ -816,7 +817,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
           return;
         }
 
-        const cameraPositionBuilder = new com.mapbox.mapboxsdk.camera.CameraPosition.Builder()
+        const cameraPositionBuilder = new com.mapbox.mapboxsdk.camera.CameraPosition.Builder(theMap.mapboxMap.getCameraPosition())
             .target(new com.mapbox.mapboxsdk.geometry.LatLng(target.lat, target.lng));
 
         if (options.bearing) {

src/mapbox.ios.ts

@@ -537,7 +537,7 @@ export class Mapbox extends MapboxCommon implements MapboxApi {
           return;
         }
 
-        let cam = MGLMapCamera.camera();
+        let cam = theMap.camera;
 
         cam.centerCoordinate = CLLocationCoordinate2DMake(target.lat, target.lng);