Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: className on compilation #1

Open
gtournie opened this issue Sep 16, 2019 · 1 comment
Open

Feature: className on compilation #1

gtournie opened this issue Sep 16, 2019 · 1 comment

Comments

@gtournie
Copy link

@Ximik Nice plugin.
I added className resolution during compilation on my repo:
https://github.com/gtournie/babel-plugin-transform-jsx-bemed

Feel free to report my changes to your repo.

@Ximik
Copy link
Owner

Ximik commented Sep 16, 2019

@gtournie Hello, thank you. I've checked through your code, it seems like a great idea for me.

This plugin was developed for the frontend with huge theme customisation requests (so it was impossible to use standard css-modules solutions). However the company changed the product requirements and the plugin has never seen the production :(

So it's very raw and I remember some issues during testing. That's why I want to have some unit tests before having any pull requests. Hopefully, I will find some time to do them (I'm also thinking about using this plugin for my current job).

Thank you for your code and feedback.

UPD: Just noticed, there are unit tests :D I will refresh everything in my memory, recheck and ask you for PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants