Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make an util for mocks used only in pointers #1813

Open
kuznetsss opened this issue Jan 8, 2025 · 0 comments
Open

Make an util for mocks used only in pointers #1813

kuznetsss opened this issue Jan 8, 2025 · 0 comments
Labels
refactoring Code improvements without logical changes testability Makes code testable and/or adds unit-tests
Milestone
Future

Comments

@kuznetsss
Copy link
Collaborator

We already have a Mock wrapper for MockSubscriptionManager https://github.com/XRPLF/clio/blob/develop/tests/common/util/MockSubscriptionManager.hpp#L108
We could make it template by inner mock type and reuse in similar places.
@kuznetsss kuznetsss added testability Makes code testable and/or adds unit-tests refactoring Code improvements without logical changes labels Jan 8, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Clio Jan 8, 2025
@godexsoft godexsoft mentioned this issue Jan 8, 2025
Merged
@godexsoft godexsoft added this to the Future milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvements without logical changes testability Makes code testable and/or adds unit-tests
Projects
Clio
Status: 📋 Backlog
Milestone
Future
Development

No branches or pull requests
2 participants
@godexsoft @kuznetsss