Skip to content

Commit 9b371cd

Browse files
authored
[Improve][Transform-V2] Remove SQL query validation on table name (apache#7020)
1 parent c5159a2 commit 9b371cd

File tree

3 files changed

+24
-56
lines changed

3 files changed

+24
-56
lines changed

seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLEngine.java

+9-2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,9 @@
2424
import org.apache.seatunnel.transform.exception.TransformException;
2525
import org.apache.seatunnel.transform.sql.SQLEngine;
2626

27+
import org.slf4j.Logger;
28+
import org.slf4j.LoggerFactory;
29+
2730
import net.sf.jsqlparser.JSQLParserException;
2831
import net.sf.jsqlparser.expression.Expression;
2932
import net.sf.jsqlparser.parser.CCJSqlParserUtil;
@@ -46,6 +49,7 @@
4649
import java.util.stream.Collectors;
4750

4851
public class ZetaSQLEngine implements SQLEngine {
52+
private static final Logger log = LoggerFactory.getLogger(ZetaSQLEngine.class);
4953
private String inputTableName;
5054
@Nullable private String catalogTableName;
5155
private SeaTunnelRowType inputRowType;
@@ -119,8 +123,11 @@ private void validateSQL(Statement statement) {
119123
String tableName = table.getName();
120124
if (!inputTableName.equalsIgnoreCase(tableName)
121125
&& !tableName.equalsIgnoreCase(catalogTableName)) {
122-
throw new IllegalArgumentException(
123-
String.format("Table name: %s not found", tableName));
126+
log.warn(
127+
"SQL table name {} is not equal to input table name {} or catalog table name {}",
128+
tableName,
129+
inputTableName,
130+
catalogTableName);
124131
}
125132
} else {
126133
throw new IllegalArgumentException("Unsupported sub table syntax");

seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/SQLTransformTest.java

+15
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,21 @@ public void testScaleSupport() {
6969
});
7070
}
7171

72+
@Test
73+
public void testQueryWithAnyTable() {
74+
SQLTransform sqlTransform =
75+
new SQLTransform(
76+
ReadonlyConfig.fromMap(
77+
new HashMap<String, Object>() {
78+
{
79+
put("query", "select * from anyTableName");
80+
}
81+
}),
82+
getCatalogTable());
83+
TableSchema tableSchema = sqlTransform.transformTableSchema();
84+
Assertions.assertEquals(4, tableSchema.getColumns().size());
85+
}
86+
7287
@Test
7388
public void testNotLoseSourceTypeAndOptions() {
7489
SQLTransform sqlTransform = new SQLTransform(READONLY_CONFIG, getCatalogTable());

seatunnel-transforms-v2/src/test/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLEngineTest.java

-54
This file was deleted.

0 commit comments

Comments
 (0)