Skip to content

Commit 3c6cf04

Browse files
Merge pull request #136 from alexandercampbell-wf/update_ring_buffer_benchmarks
queue: update benchmarks with suggested fix
2 parents c32ff62 + b56a995 commit 3c6cf04

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

queue/ring_test.go

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -280,30 +280,32 @@ func BenchmarkRBLifeCycle(b *testing.B) {
280280
}
281281

282282
func BenchmarkRBPut(b *testing.B) {
283-
rbs := make([]*RingBuffer, 0, b.N)
284-
285-
for i := 0; i < b.N; i++ {
286-
rbs = append(rbs, NewRingBuffer(2))
287-
}
283+
rb := NewRingBuffer(uint64(b.N))
288284

289285
b.ResetTimer()
290286

291287
for i := 0; i < b.N; i++ {
292-
rbs[i].Put(i)
288+
ok, err := rb.Offer(i)
289+
if !ok {
290+
b.Fail()
291+
}
292+
if err != nil {
293+
b.Log(err)
294+
b.Fail()
295+
}
293296
}
294297
}
295298

296299
func BenchmarkRBGet(b *testing.B) {
297-
rbs := make([]*RingBuffer, 0, b.N)
300+
rb := NewRingBuffer(uint64(b.N))
298301

299302
for i := 0; i < b.N; i++ {
300-
rbs = append(rbs, NewRingBuffer(2))
301-
rbs[i].Put(i)
303+
rb.Offer(i)
302304
}
303305

304306
b.ResetTimer()
305307

306308
for i := 0; i < b.N; i++ {
307-
rbs[i].Get()
309+
rb.Get()
308310
}
309311
}

0 commit comments

Comments
 (0)