Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton Style Refactor #2958

Closed
myvuuu opened this issue Oct 4, 2024 · 0 comments
Closed

Skeleton Style Refactor #2958

myvuuu opened this issue Oct 4, 2024 · 0 comments
Assignees
@thunguyen19
Milestone
13.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Oct 4, 2024

🚀 Feature Proposal

Skeleton style re-factor is needed with the new cs prop. We will need to update this component to use the new system level tokens via CSS variables.

Acceptance Criteria:

  • Skeleton is tied to CSS variables system tokens
  • The enhancements made are backwards compatible
  • Update v13 upgrade guide
  • Update v13 comms

Motivation

This will utilize the new cs prop and we now have access to new css properties
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Oct 4, 2024
@myvuuu myvuuu mentioned this issue Oct 4, 2024
Open
12 tasks
@myvuuu myvuuu added this to the 13.0.0 milestone Oct 4, 2024
@thunguyen19 thunguyen19 mentioned this issue Jan 2, 2025
Merged
10 tasks
alanbsmith pushed a commit that referenced this issue Jan 23, 2025
@thunguyen19
feat: Refactor Skeleton to use our new styling utilities and new toke…
b5251e8 
…ns (#3088)

Fixes: #2958

[category:Components]

Release Note:
We've updated`Skeleton` to use our new Tokens and styling utilities. The React interface has not changed, but CSS variables are now used for dynamic properties.
@jaclynjessup jaclynjessup moved this from 🆕 New to ✅ Done in Canvas Kit Jan 24, 2025
@jaclynjessup jaclynjessup closed this as completed by moving to ✅ Done in Canvas Kit Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thunguyen19 thunguyen19

Labels
None yet
Projects
Canvas Kit
Status: ✅ Done
Milestone
13.0.0
Development

No branches or pull requests
3 participants
@jaclynjessup @thunguyen19 @myvuuu