Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlink / External Hyperlink Styles Refactor #2955

Closed
myvuuu opened this issue Oct 4, 2024 · 0 comments
Closed

Hyperlink / External Hyperlink Styles Refactor #2955

myvuuu opened this issue Oct 4, 2024 · 0 comments
Assignees
@mannycarrera4
Milestone
13.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Oct 4, 2024

🚀 Feature Proposal

Hyperlink / External Hyperlink style re-factor is needed with the new cs prop. We will need to update this component to use the new system level tokens via CSS variables.

Acceptance Criteria:

  • Hyperlink / External Hyperlink is tied to CSS variables system tokens
  • The enhancements made are backwards compatible
  • Update v13 upgrade guide
  • Update v13 comms

Motivation

This will utilize the new cs prop and we now have access to new css properties
@myvuuu myvuuu mentioned this issue Oct 4, 2024
Open
12 tasks
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Oct 4, 2024
@myvuuu myvuuu added this to the 13.0.0 milestone Oct 4, 2024
@mannycarrera4 mannycarrera4 mentioned this issue Jan 14, 2025
Merged
@myvuuu myvuuu moved this from 🆕 New to 🏗 In progress in Canvas Kit Jan 21, 2025
@mannycarrera4 mannycarrera4 moved this from 🏗 In progress to 👀 In review in Canvas Kit Jan 21, 2025
alanbsmith pushed a commit that referenced this issue Jan 24, 2025
@mannycarrera4
feat!: Refactor External Hyperlink to use new styling utilities (#3101)
8690580 
Fixes: #2955

[category:Components]

Release Note:
We've updated `ExternalHyperlink` to use our new styling utilities and tokens.

### BREAKING CHANGES
`iconLabel` is now a *required* prop. We've removed the default `aria-label` of `Opens link in new window` to better support internationalization. You must provide a value to `iconLabel`.

Co-authored-by: manuel.carrera <[email protected]>
@jaclynjessup jaclynjessup moved this from 👀 In review to ✅ Done in Canvas Kit Jan 24, 2025
@jaclynjessup jaclynjessup closed this as completed by moving to ✅ Done in Canvas Kit Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mannycarrera4 mannycarrera4

Labels
None yet
Projects
Canvas Kit
Status: ✅ Done
Milestone
13.0.0
Development

No branches or pull requests
3 participants
@mannycarrera4 @jaclynjessup @myvuuu