Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expandable Styles Refactor #2954

Closed
myvuuu opened this issue Oct 4, 2024 · 0 comments · Fixed by #3128
Closed

Expandable Styles Refactor #2954

myvuuu opened this issue Oct 4, 2024 · 0 comments · Fixed by #3128
Assignees
@williamjstanton
Milestone
13.0.0

Comments

@myvuuu
Copy link
Collaborator

myvuuu commented Oct 4, 2024

🚀 Feature Proposal

Expandable style re-factor is needed with the new cs prop. We will need to update this component to use the new system level tokens via CSS variables.

Acceptance Criteria:

  • Expandable is tied to CSS variables system tokens
  • The enhancements made are backwards compatible
  • Update v13 upgrade guide
  • Update v13 comms

Motivation

This will utilize the new cs prop and we now have access to new css properties
@jaclynjessup jaclynjessup moved this to 🆕 New in Canvas Kit Oct 4, 2024
@myvuuu myvuuu mentioned this issue Oct 4, 2024
Open
12 tasks
@myvuuu myvuuu added this to the 13.0.0 milestone Oct 4, 2024
@jaclynjessup jaclynjessup moved this from 🆕 New to 🏗 In progress in Canvas Kit Jan 24, 2025
@williamjstanton williamjstanton mentioned this issue Feb 8, 2025
Merged
10 tasks
@jaclynjessup jaclynjessup moved this from 🏗 In progress to 👀 In review in Canvas Kit Feb 13, 2025
alanbsmith pushed a commit that referenced this issue Mar 10, 2025
@williamjstanton @josh-bagwell
chore: Expandable component style refactor (#3128)
7dab7ee 
Fixes: #2954   

Expandable style re-factor is needed with the new cs prop. We will need to update this component to use the new system level tokens via CSS variables.

[category:Tokens]

Release Note:
- The `ExpandableTarget` component is now rendering the `BaseButton` component, and may have some small impact on the visual styling of the keyboard focus ring. 
- The `ExpandableIcon` stencil is extending the `SystemIcon` stencil, and may have had an impact on the chevron icon color. 
- Fixed an accessibility bug in the `Avatar` component where an `aria-label` string was rendered on a generic HTML element that did not have an explicit or implicit `role`

Co-authored-by: @josh-bagwell <[email protected]>
Co-authored-by: manuel.carrera <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Canvas Kit Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamjstanton williamjstanton

Labels
None yet
Projects
Canvas Kit
Status: ✅ Done
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

chore: Expandable component style refactor williamjstanton/canvas-kit
2 participants
@williamjstanton @myvuuu