Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of phpcs-changed package for linting #232

Open
shivapoudel opened this issue Apr 3, 2023 · 1 comment
Open

Use of phpcs-changed package for linting #232

shivapoudel opened this issue Apr 3, 2023 · 1 comment
Labels
[Type] Project Management Meta-issues related to WP Notify project management.

Comments

@shivapoudel
Copy link

What problem does this address?

Implement phpcs-changed so that only changed files are listed.

What is your proposed solution?

https://github.com/sirbrillig/phpcs-changed

@erikyo
Copy link
Collaborator

erikyo commented Apr 3, 2023

Ciao @shivapoudel!

first I wanted to thank you for your contribution, it is always very welcome!

I wanted to kind ask if you have seen that recently @johnhooks implemented lint-staged which I think does about the same thing and we were wondering what benefits we might get with the package you propose.

PS. you are invited to Wednesday's meeting in the wp-notification channel -- we are in shortage of php experts 😉

@Sephsekla Sephsekla added the [Type] Project Management Meta-issues related to WP Notify project management. label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Project Management Meta-issues related to WP Notify project management.
Projects
None yet
Development

No branches or pull requests

3 participants