Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Analyzing Abstract_Check_Runner Class for Complexity Reduction #229

Open
1 task done
mukeshpanchal27 opened this issue Jul 12, 2023 · 0 comments
Open
1 task done
Labels
[Type] Enhancement A suggestion for improvement of an existing feature

Comments

@mukeshpanchal27
Copy link
Member

Is your enhancement related to a problem? Please describe.

Following up on PR #228, during the code review process, we encountered a warning related to excessive class complexity in the file plugin-check/includes/Checker/Abstract_Check_Runner.php at line 19. The warning message received was:

ExcessiveClassComplexity: The class Abstract_Check_Runner has an overall complexity of 54 which is very high. The configured complexity threshold is 50.

To address this warning, it is recommended that we refactor the code of the Abstract_Check_Runner class to reduce its complexity. Currently, we have temporarily suppressed the warning by adding @SuppressWarnings(PHPMD.ExcessiveClassComplexity) in the class docblock.

This issue aims to investigate and analyze the Abstract_Check_Runner class in order to identify areas where complexity can be reduced.

Please feel free to provide any additional insights or suggestions for the refactoring process.

cc. @swissspidy

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@mukeshpanchal27 mukeshpanchal27 added the [Type] Enhancement A suggestion for improvement of an existing feature label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant