Give repeated post links unique accessible names - #94
Closed
henriqueiamarino wants to merge 1 commit into
Closed
henriqueiamarino wants to merge 1 commit into
henriqueiamarino wants to merge 1 commit into
Conversation
The comments call to action and linked post dates repeat for every post in a loop with identical accessible names and different targets. The binding now appends the post title as screen reader text, and a render filter does the same inside linked post dates — every such link reads uniquely while the visible design stays untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
the
[Area] Theme Functions
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47.
Both cases from @carolinan's accessibility-ready testing, fixed without touching the visible design:
ipsum/comments-ctabinding now appends the post title as screen reader text — the accessible name becomes "Join the conversation on Post title" / "Be the first to comment on Post title", unique per post, with the visible label leading the name (safe for label-in-name).render_block_core/post-datefilter appends the post title as screen reader text inside the link whenever the block is set to link — one filter covers every date link in the theme (index, archive pack, Keep Reading, sidebar), so posts published on the same day no longer share a name.Verified on a running index: 20 date links → 20 unique accessible names, both CTA states carrying their post title, no visual change.
The post-date case is ultimately the block's gap — it affects any theme that links dates — and may be worth raising upstream.
🤖 Generated with Claude Code