Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first pull request, @ikamal7! We'll take a look soon. |
Adds aria-label attributes that include the post title to both the linked post-date and the Comments CTA links, so each link announces a unique accessible name to screen readers. Fixes WordPress#47
f09a924 to
adab85b
Compare
|
I'm not a native English speaker, but I don't think adding a colon between the data is helpful. I would personally prefer if the link on the date was just removed. I don't think each post needs four to five links: Please allow more contributors to chime in before making more changes. |
| $post_title | ||
| ); | ||
|
|
||
| return str_replace( |
There was a problem hiding this comment.
I don't think a theme should take into its hands this kind of DOM manipulation. Something like this should be done in core if it was really needed, else every theme would need this code.
There was a problem hiding this comment.
I can agree, on the other hand, users can solve this without a change in Gutenberg, by removing the link from the date or by selecting a format that is unique, not only the year, month and day.
Agree, I think that's what the PR should be |
|
I don't mind removing the date links—fine by me from the design side. |
Description
Resolves ambiguous link text accessibility issues where multiple posts share the same accessible name:
Post date links — Multiple posts published on the same day announced identical names to screen readers. Added a filter that appends the post title to an on the linked date.
Comments CTA links — The "Join the conversation" / "Be the first to comment" links repeated the same text across posts. The block binding callback now includes the post title in an .
Both fixes follow the pattern: , making each link uniquely identifiable.
Fixes #47