Skip to content

Commit ad4acb2

Browse files
author
Nikan Radan
committed
Merge Conflict Fix
2 parents 7ee680a + f91339e commit ad4acb2

File tree

336 files changed

+1962
-896
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

336 files changed

+1962
-896
lines changed

.github/CODEOWNERS

+2-5
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
# Blocks
1616
/packages/block-library @ajitbohra @fabiankaegy
17-
/packages/block-library/src/gallery @geriux
17+
/packages/block-library/src/gallery
1818
/packages/block-library/src/comment-template @michalczaplinski
1919
/packages/block-library/src/comments @michalczaplinski
2020
/packages/block-library/src/table-of-contents @ZebulanStanphill
@@ -138,10 +138,7 @@
138138
/lib/compat/*/html-api @dmsnell
139139
/lib/experimental/rest-api.php @timothybjacobs
140140
/lib/experimental/class-wp-rest-* @timothybjacobs
141-
/lib/experimental/class-wp-rest-block-editor-settings-controller.php @timothybjacobs @spacedmonkey @geriux
142-
143-
# Native
144-
/packages/components/src/mobile/global-styles-context @geriux
141+
/lib/experimental/class-wp-rest-block-editor-settings-controller.php @timothybjacobs @spacedmonkey
145142

146143
# Native (Unowned)
147144
*.native.js

.github/workflows/gradle-wrapper-validation.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ jobs:
1111
with:
1212
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
1313
- name: Validate checksums
14-
uses: gradle/actions/wrapper-validation@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 # v4.2.1
14+
uses: gradle/actions/wrapper-validation@0bdd871935719febd78681f197cd39af5b6e16a6 # v4.2.2

.github/workflows/rnmobile-android-runner.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
3030

3131
- name: Use desired version of Java
32-
uses: actions/setup-java@8df1039502a15bceb9433410b1a100fbe190c53b # v4.5.0
32+
uses: actions/setup-java@7a6d8a8234af8eb26422e24e3006232cccaa061b # v4.6.0
3333
with:
3434
distribution: 'corretto'
3535
java-version: '17'
@@ -48,7 +48,7 @@ jobs:
4848
run: npm run native test:e2e:setup
4949

5050
- name: Gradle cache
51-
uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 # v4.2.1
51+
uses: gradle/actions/setup-gradle@0bdd871935719febd78681f197cd39af5b6e16a6 # v4.2.2
5252

5353
# AVD cache disabled as it caused emulator termination to hang indefinitely.
5454
# https://github.com/ReactiveCircus/android-emulator-runner/issues/385

.github/workflows/rnmobile-ios-runner.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
with:
2929
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
3030

31-
- uses: ruby/setup-ruby@a2bbe5b1b236842c1cb7dd11e8e3b51e0a616acc # v1.202.0
31+
- uses: ruby/setup-ruby@4a9ddd6f338a97768b8006bf671dfbad383215f4 # v1.207.0
3232
with:
3333
# `.ruby-version` file location
3434
working-directory: packages/react-native-editor/ios

.github/workflows/storybook-check.yml

+27
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
name: Check Storybook build
2+
3+
on: pull_request
4+
5+
# Cancels all previous workflow runs for pull requests that have not completed.
6+
concurrency:
7+
# The concurrency group contains the workflow name and the branch name for pull requests
8+
# or the commit hash for any other events.
9+
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }}
10+
cancel-in-progress: true
11+
12+
jobs:
13+
check:
14+
runs-on: ubuntu-latest
15+
if: ${{ github.repository == 'WordPress/gutenberg' || github.event_name == 'pull_request' }}
16+
17+
steps:
18+
- name: Checkout
19+
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
20+
with:
21+
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
22+
23+
- name: Setup Node.js and install dependencies
24+
uses: ./.github/setup-node
25+
26+
- name: Build Storybook
27+
run: npm run storybook:build

.github/workflows/unit-test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ jobs:
188188
# dependency versions are installed and cached.
189189
##
190190
- name: Set up PHP
191-
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
191+
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # v2.32.0
192192
with:
193193
php-version: '${{ matrix.php }}'
194194
ini-file: development
@@ -283,7 +283,7 @@ jobs:
283283
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
284284

285285
- name: Set up PHP
286-
uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
286+
uses: shivammathur/setup-php@9e72090525849c5e82e596468b86eb55e9cc5401 # v2.32.0
287287
with:
288288
php-version: '7.4'
289289
coverage: none

backport-changelog/readme.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ The filename is the Core PR number.
2020

2121
For example, if your Core PR number is `1234` and is slated to be part of the WordPress 6.9 release, the filename will be `1234.md`, and will be placed in the `/backport-changelog/6.9` directory.
2222

23-
The content of the markdown file should be the Github URL of the Core PR, followed by a list of Gutenberg PR Github URLs whose changes are backported in the Core PR.
23+
The content of the markdown file should be the GitHub URL of the Core PR, followed by a list of Gutenberg PR GitHub URLs whose changes are backported in the Core PR.
2424

2525
A single Core PR may contain changes from one or multiple Gutenberg PRs.
2626

@@ -51,7 +51,7 @@ For the backport changelog, Gutenberg uses individual files as opposed to a sing
5151

5252
Some Gutenberg PRs may be flagged as needing a core backport PR when they don't, for example when the PR contains minor comment changes, or the changes already exist in Core.
5353

54-
For individual PRs, there are two Github labels that can be used to exclude a PR from the backport changelog CI check:
54+
For individual PRs, there are two GitHub labels that can be used to exclude a PR from the backport changelog CI check:
5555

5656
- `Backport from WordPress Core` - Indicates that the PR is a backport from WordPress Core and doesn't need a Core PR.
5757
- `No Core Sync Required` - Indicates that any changes do not need to be synced to WordPress Core.

bin/api-docs/gen-block-lib-list.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@ function processObjWithInnerKeys( obj ) {
108108
* not disabled. So adding { color: 'link' } support also brings along
109109
* background and text.
110110
*
111-
* @param {Object} supports - keys supported by blokc
111+
* @param {Object} supports - keys supported by block
112112
* @return {Object} supports augmented with defaults
113113
*/
114114
function augmentSupports( supports ) {
115115
if ( 'color' in supports ) {
116-
// If backgroud or text is not specified (true or false)
116+
// If background or text is not specified (true or false)
117117
// then add it as true.a
118118
if ( ! ( 'background' in supports.color ) ) {
119119
supports.color.background = true;

bin/plugin/commands/changelog.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ const LABEL_TYPE_MAPPING = {
8888
};
8989

9090
/**
91-
* Mapping of label names to arbitary features in the release notes.
91+
* Mapping of label names to arbitrary features in the release notes.
9292
*
9393
* Mapping a given label to a feature will guarantee it will be categorised
9494
* under that feature name in the changelog within each section.
@@ -274,7 +274,7 @@ function mapLabelsToFeatures( labels ) {
274274
*
275275
* @param {string[]} labels Label names.
276276
*
277-
* @return {boolean} whether or not the issue's is labbeled as block specific
277+
* @return {boolean} whether or not the issue's is labeled as block specific
278278
*/
279279
function getIsBlockSpecificIssue( labels ) {
280280
return !! labels.find( ( label ) => label.startsWith( '[Block] ' ) );
@@ -343,7 +343,7 @@ function getIssueFeature( issue ) {
343343

344344
// 1. Prefer explicit mapping of label to feature.
345345
if ( featureCandidates.length ) {
346-
// Get occurances of the feature labels.
346+
// Get occurrences of the feature labels.
347347
const featureCounts = featureCandidates.reduce(
348348
/**
349349
* @param {Record<string,number>} acc Accumulator
@@ -941,7 +941,7 @@ function skipCreatedByBots( pullRequests ) {
941941
}
942942

943943
/**
944-
* Produces the formatted markdown for the contributor props seciton.
944+
* Produces the formatted markdown for the contributor props section.
945945
*
946946
* @param {IssuesListForRepoResponseItem[]} pullRequests List of pull requests.
947947
*

bin/plugin/commands/test/changelog.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ describe( 'getIssueFeature', () => {
260260
name: '[Package] This package',
261261
},
262262
{
263-
name: '[Feature] Cool Feature', // Should have priority despite prescence of block specific label.
263+
name: '[Feature] Cool Feature', // Should have priority despite presence of block specific label.
264264
},
265265
{
266266
name: '[Package] Another One',

docs/contributors/code/release.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ It's important to check that:
234234
- the plugin from the directory works as expected
235235
- the ZIP contents (see [Downloads](https://plugins.trac.wordpress.org/browser/gutenberg/)) looks correct (doesn't have anything obvious missing)
236236
- the [Gutenberg SVN repo](https://plugins.trac.wordpress.org/browser/gutenberg/) has two new commits (see [the log](https://plugins.trac.wordpress.org/browser/gutenberg/)):
237-
- the `trunk` folder should have "Commiting version X.Y.Z"
237+
- the `trunk` folder should have "Committing version X.Y.Z"
238238
- there is a new `tags/X.Y.Z` folder with the same contents as `trunk` whose latest commit is "Tagging version X.Y.Z"
239239

240240
Most likely, the tag folder couldn't be created. This is a [known issue](https://plugins.trac.wordpress.org/browser/gutenberg/) that [can be fixed manually](https://github.com/WordPress/gutenberg/issues/55295#issuecomment-1759292978).

docs/manifest.json

+6
Original file line numberDiff line numberDiff line change
@@ -1967,6 +1967,12 @@
19671967
"markdown_source": "../packages/undo-manager/README.md",
19681968
"parent": "packages"
19691969
},
1970+
{
1971+
"title": "@wordpress/upload-media",
1972+
"slug": "packages-upload-media",
1973+
"markdown_source": "../packages/upload-media/README.md",
1974+
"parent": "packages"
1975+
},
19701976
{
19711977
"title": "@wordpress/url",
19721978
"slug": "packages-url",

docs/reference-guides/block-api/block-bindings.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ The function to register a custom source is `registerBlockBindingsSource( args )
148148

149149
- `args`: `object` with the following structure:
150150
- `name`: `string` with the unique and machine-readable name.
151-
- `label`: `string` with the human readable name of the custom source. In case it was defined already on the server, the server label will be overriden by this one, in that case, it is not recommended to be defined here. (optional)
151+
- `label`: `string` with the human readable name of the custom source. In case it was defined already on the server, the server label will be overridden by this one, in that case, it is not recommended to be defined here. (optional)
152152
- `usesContext`: `array` with the block context that the custom source may need. In case it was defined already on the server, it should not be defined here. (optional)
153153
- `getValues`: `function` that retrieves the values from the source. (optional)
154154
- `setValues`: `function` that allows updating the values connected to the source. (optional)

docs/reference-guides/core-blocks.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ Hide and show additional content. ([Source](https://github.com/WordPress/gutenbe
255255
- **Name:** core/details
256256
- **Category:** text
257257
- **Supports:** align (full, wide), anchor, color (background, gradients, link, text), interactivity (clientNavigation), layout (~~allowEditing~~), spacing (blockGap, margin, padding), typography (fontSize, lineHeight), ~~html~~
258-
- **Attributes:** showContent, summary
258+
- **Attributes:** allowedBlocks, showContent, summary
259259

260260
## Embed
261261

@@ -512,7 +512,7 @@ Display a list of all pages. ([Source](https://github.com/WordPress/gutenberg/tr
512512
- **Name:** core/page-list
513513
- **Category:** widgets
514514
- **Allowed Blocks:** core/page-list-item
515-
- **Supports:** interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
515+
- **Supports:** color (background, gradients, link, text), interactivity (clientNavigation), spacing (margin, padding), typography (fontSize, lineHeight), ~~html~~, ~~reusable~~
516516
- **Attributes:** isNested, parentPageID
517517

518518
## Page List Item
@@ -811,7 +811,7 @@ Display entries from any RSS or Atom feed. ([Source](https://github.com/WordPres
811811

812812
- **Name:** core/rss
813813
- **Category:** widgets
814-
- **Supports:** align, interactivity (clientNavigation), ~~html~~
814+
- **Supports:** align, color (background, gradients, link, text), interactivity (clientNavigation), ~~html~~
815815
- **Attributes:** blockLayout, columns, displayAuthor, displayDate, displayExcerpt, excerptLength, feedURL, itemsToShow
816816

817817
## Search

docs/reference-guides/data/data-core-block-editor.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -714,7 +714,7 @@ Returns the list of patterns based on their declared `blockTypes` and a block's
714714
_Parameters_
715715

716716
- _state_ `Object`: Editor state.
717-
- _blockNames_ `string|string[]`: Block's name or array of block names to find matching pattens.
717+
- _blockNames_ `string|string[]`: Block's name or array of block names to find matching patterns.
718718
- _rootClientId_ `?string`: Optional target root client ID.
719719

720720
_Returns_

docs/reference-guides/data/data-core.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -878,7 +878,7 @@ _Returns_
878878

879879
### redo
880880

881-
Action triggered to redo the last undoed edit to an entity record, if any.
881+
Action triggered to redo the last undone edit to an entity record, if any.
882882

883883
### saveEditedEntityRecord
884884

docs/reference-guides/interactivity-api/core-concepts/using-typescript.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ These are the core principles of TypeScript's interaction with the Interactivity
66

77
- **Inferred client types**: When you create a store using the `store` function, TypeScript automatically infers the types of the store's properties (`state`, `actions`, etc.). This means that you can often get away with just writing plain JavaScript objects, and TypeScript will figure out the types for you.
88
- **Explicit server types**: When dealing with data defined on the server, like local context or the initial values of the global state, you can explicitly define its types to ensure that everything is correctly typed.
9-
- **Mutiple store parts**: Even if your store is split into multiple parts, you can define or infer the types of each part of the store and then merge them into a single type that represents the entire store.
9+
- **Multiple store parts**: Even if your store is split into multiple parts, you can define or infer the types of each part of the store and then merge them into a single type that represents the entire store.
1010
- **Typed external stores**: You can import typed stores from external namespaces, allowing you to use other plugins' functionality with type safety.
1111

1212
## Installing `@wordpress/interactivity` locally
@@ -495,7 +495,7 @@ There's something to keep in mind when when using asynchronous actions. Just lik
495495
counter: 0,
496496
},
497497
actions: {
498-
*delayedReturn(): Generator< uknown, number, uknown > {
498+
*delayedReturn(): Generator< unknown, number, unknown > {
499499
yield new Promise( ( r ) => setTimeout( r, 1000 ) );
500500
return state.counter; // Now this is correctly inferred.
501501
},

docs/reference-guides/interactivity-api/iapi-about.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ Additionally, with a standard, **WordPress can absorb the maximum amount of comp
186186

187187
_Complexities absorbed by the standard_
188188

189-
<img alt="Two columns table comparing some aspects with and without a standard. Without a standard, block developers have to take care of everything, while having a standard. Totally handled by the standard: Tooling, hydration, integrating it with WordPress, SSR of the interactive parts, inter-block communication, and frontend performance. Partially handled: Security, accessibility, and best practices. Developer responsibility: Block logic. In the without a standard column, everything is under the developer responsability." width=60% src="https://make.wordpress.org/core/files/2023/03/standard-graph.png">
189+
<img alt="Two columns table comparing some aspects with and without a standard. Without a standard, block developers have to take care of everything, while having a standard. Totally handled by the standard: Tooling, hydration, integrating it with WordPress, SSR of the interactive parts, inter-block communication, and frontend performance. Partially handled: Security, accessibility, and best practices. Developer responsibility: Block logic. In the without a standard column, everything is under the developer responsibility." width=60% src="https://make.wordpress.org/core/files/2023/03/standard-graph.png">
190190

191191

192192
With this absorption, less knowledge is required to create interactive blocks, and developers have fewer decisions to worry about.

lib/class-wp-theme-json-gutenberg.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -3419,7 +3419,7 @@ protected static function should_override_preset( $theme_json, $path, $override
34193419

34203420
/**
34213421
* Returns the default slugs for all the presets in an associative array
3422-
* whose keys are the preset paths and the leafs is the list of slugs.
3422+
* whose keys are the preset paths and the leaves is the list of slugs.
34233423
*
34243424
* For example:
34253425
*

lib/experimental/media/load.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -302,24 +302,24 @@ function gutenberg_add_crossorigin_attributes( string $html ): string {
302302

303303
$processor->set_bookmark( 'resume' );
304304

305-
$seeked = false;
305+
$sought = false;
306306

307307
$crossorigin = $processor->get_attribute( 'crossorigin' );
308308

309309
$url = $processor->get_attribute( $tags[ $tag ] );
310310

311311
if ( is_string( $url ) && ! str_starts_with( $url, $site_url ) && ! str_starts_with( $url, '/' ) && ! is_string( $crossorigin ) ) {
312312
if ( 'SOURCE' === $tag ) {
313-
$seeked = $processor->seek( 'audio-video-parent' );
313+
$sought = $processor->seek( 'audio-video-parent' );
314314

315-
if ( $seeked ) {
315+
if ( $sought ) {
316316
$processor->set_attribute( 'crossorigin', 'anonymous' );
317317
}
318318
} else {
319319
$processor->set_attribute( 'crossorigin', 'anonymous' );
320320
}
321321

322-
if ( $seeked ) {
322+
if ( $sought ) {
323323
$processor->seek( 'resume' );
324324
$processor->release_bookmark( 'audio-video-parent' );
325325
}

lib/experimental/sync/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
The signaling server allows multiple clients to exchange messages with each other through various communication topics.
44

5-
Topics are not defined upfront, but clients define them by subscribing to them. By subscribing to a given topic, the client tells the server to keep track of its unread messages in the given topic. By unsubscribing from a topic, the client tells the server to free the bookeeping it maintains for the given client and topic.
5+
Topics are not defined upfront, but clients define them by subscribing to them. By subscribing to a given topic, the client tells the server to keep track of its unread messages in the given topic. By unsubscribing from a topic, the client tells the server to free the bookkeeping it maintains for the given client and topic.
66

77
Every client communicates with the server via `GET` or `POST`. Clients must have a unique identifier, which can be randomly generated. This identifier should be included as a parameter named `subscriber_id` in every request.
88

0 commit comments

Comments
 (0)