Skip to content

Commit af42dde

Browse files
schlesseraschlessera
authored
Merge pull request #925 from WordPress/feature/ghactions-add-actionlint
2 parents a928dab + 4f059f5 commit af42dde

File tree

5 files changed

+53
-31
lines changed

5 files changed

+53
-31
lines changed

‎.github/workflows/cs.yml‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,28 @@ concurrency:
1414
cancel-in-progress: true
1515

1616
jobs:
17+
actionlint: #----------------------------------------------------------------------
18+
name: 'Check GHA workflows'
19+
runs-on: ubuntu-latest
20+
21+
steps:
22+
- name: Checkout code
23+
uses: actions/checkout@v4
24+
25+
- name: Add problem matcher
26+
if: ${{ github.event_name == 'pull_request' }}
27+
shell: bash
28+
run: |
29+
curl -o actionlint-matcher.json https://raw.githubusercontent.com/rhysd/actionlint/main/.github/actionlint-matcher.json
30+
echo "::add-matcher::actionlint-matcher.json"
31+
32+
- name: Check workflow files
33+
env:
34+
SHELLCHECK_OPTS: --exclude=SC2129
35+
uses: docker://rhysd/actionlint:latest
36+
with:
37+
args: -color
38+
1739
phpcs: #----------------------------------------------------------------------
1840
name: 'PHPCS'
1941
runs-on: ubuntu-latest

‎.github/workflows/quicktest.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ jobs:
6767
- name: Start test server
6868
run: |
6969
PORT=8080 vendor/bin/start.sh
70-
echo "REQUESTS_TEST_HOST_HTTP=localhost:8080" >> $GITHUB_ENV
70+
echo "REQUESTS_TEST_HOST_HTTP=localhost:8080" >> "$GITHUB_ENV"
7171
7272
- name: Ping localhost domain
7373
run: ping -c1 localhost
@@ -76,10 +76,10 @@ jobs:
7676
run: |
7777
PORT=9002 tests/utils/proxy/start.sh
7878
PORT=9003 AUTH="test:pass" tests/utils/proxy/start.sh
79-
echo "REQUESTS_HTTP_PROXY=localhost:9002" >> $GITHUB_ENV
80-
echo "REQUESTS_HTTP_PROXY_AUTH=localhost:9003" >> $GITHUB_ENV
81-
echo "REQUESTS_HTTP_PROXY_AUTH_USER=test" >> $GITHUB_ENV
82-
echo "REQUESTS_HTTP_PROXY_AUTH_PASS=pass" >> $GITHUB_ENV
79+
echo "REQUESTS_HTTP_PROXY=localhost:9002" >> "$GITHUB_ENV"
80+
echo "REQUESTS_HTTP_PROXY_AUTH=localhost:9003" >> "$GITHUB_ENV"
81+
echo "REQUESTS_HTTP_PROXY_AUTH_USER=test" >> "$GITHUB_ENV"
82+
echo "REQUESTS_HTTP_PROXY_AUTH_PASS=pass" >> "$GITHUB_ENV"
8383
8484
- name: Ensure the HTTPS test instance on Render is spun up
8585
run: curl -s -I https://requests-test-server.onrender.com/ > /dev/null
@@ -92,7 +92,7 @@ jobs:
9292

9393
- name: Grab PHPUnit version
9494
id: phpunit_version
95-
run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT
95+
run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> "$GITHUB_OUTPUT"
9696

9797
- name: Run the unit tests (PHPUnit < 10)
9898
if: ${{ ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }}

‎.github/workflows/test.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jobs:
9191
- name: Start test server
9292
run: |
9393
PORT=8080 vendor/bin/start.sh
94-
echo "REQUESTS_TEST_HOST_HTTP=localhost:8080" >> $GITHUB_ENV
94+
echo "REQUESTS_TEST_HOST_HTTP=localhost:8080" >> "$GITHUB_ENV"
9595
9696
- name: Ping localhost domain
9797
run: ping -c1 localhost
@@ -100,10 +100,10 @@ jobs:
100100
run: |
101101
PORT=9002 tests/utils/proxy/start.sh
102102
PORT=9003 AUTH="test:pass" tests/utils/proxy/start.sh
103-
echo "REQUESTS_HTTP_PROXY=localhost:9002" >> $GITHUB_ENV
104-
echo "REQUESTS_HTTP_PROXY_AUTH=localhost:9003" >> $GITHUB_ENV
105-
echo "REQUESTS_HTTP_PROXY_AUTH_USER=test" >> $GITHUB_ENV
106-
echo "REQUESTS_HTTP_PROXY_AUTH_PASS=pass" >> $GITHUB_ENV
103+
echo "REQUESTS_HTTP_PROXY=localhost:9002" >> "$GITHUB_ENV"
104+
echo "REQUESTS_HTTP_PROXY_AUTH=localhost:9003" >> "$GITHUB_ENV"
105+
echo "REQUESTS_HTTP_PROXY_AUTH_USER=test" >> "$GITHUB_ENV"
106+
echo "REQUESTS_HTTP_PROXY_AUTH_PASS=pass" >> "$GITHUB_ENV"
107107
108108
- name: Ensure the HTTPS test instance on Render is spun up
109109
run: curl -s -I https://requests-test-server.onrender.com/ > /dev/null
@@ -116,7 +116,7 @@ jobs:
116116

117117
- name: Grab PHPUnit version
118118
id: phpunit_version
119-
run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT
119+
run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> "$GITHUB_OUTPUT"
120120

121121
- name: Run the unit tests, no code coverage (PHPUnit < 10)
122122
if: ${{ matrix.coverage == false && ! startsWith( steps.phpunit_version.outputs.VERSION, '10.' ) }}

‎.github/workflows/update-cacert.yml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,18 @@ jobs:
4040
PR_NUM: ${{ github.event.pull_request.number }}
4141
run: |
4242
if [[ "${{ github.event_name }}" == 'schedule' ]]; then
43-
echo "BASE=develop" >> $GITHUB_OUTPUT
44-
echo "PR_BRANCH=feature/auto-update-cacert" >> $GITHUB_OUTPUT
43+
echo "BASE=develop" >> "$GITHUB_OUTPUT"
44+
echo "PR_BRANCH=feature/auto-update-cacert" >> "$GITHUB_OUTPUT"
4545
elif [[ "${{ github.event_name }}" == 'push' ]]; then
4646
# Pull requests should always go to develop, even when triggered via a push to stable.
47-
echo "BASE=develop" >> $GITHUB_OUTPUT
48-
echo "PR_BRANCH=feature/auto-update-cacert" >> $GITHUB_OUTPUT
47+
echo "BASE=develop" >> "$GITHUB_OUTPUT"
48+
echo "PR_BRANCH=feature/auto-update-cacert" >> "$GITHUB_OUTPUT"
4949
elif [[ $PR_NUM != '' ]]; then # = PR or manual (re-)run for a workflow triggered by a PR.
50-
echo "BASE=$HEAD_REF" >> $GITHUB_OUTPUT
51-
echo "PR_BRANCH=feature/auto-update-cacert-$PR_NUM" >> $GITHUB_OUTPUT
50+
echo "BASE=$HEAD_REF" >> "$GITHUB_OUTPUT"
51+
echo "PR_BRANCH=feature/auto-update-cacert-$PR_NUM" >> "$GITHUB_OUTPUT"
5252
else # = manual run.
53-
echo "BASE=$HEAD_REF" >> $GITHUB_OUTPUT
54-
echo "PR_BRANCH=feature/auto-update-cacert-misc" >> $GITHUB_OUTPUT
53+
echo "BASE=$HEAD_REF" >> "$GITHUB_OUTPUT"
54+
echo "PR_BRANCH=feature/auto-update-cacert-misc" >> "$GITHUB_OUTPUT"
5555
fi
5656
5757
- name: Checkout code
@@ -83,7 +83,7 @@ jobs:
8383
# http://man7.org/linux/man-pages/man1/date.1.html
8484
- name: "Get date"
8585
id: get-date
86-
run: echo "DATE=$(/bin/date -u "+%F")" >> $GITHUB_OUTPUT
86+
run: echo "DATE=$(/bin/date -u "+%F")" >> "$GITHUB_OUTPUT"
8787

8888
- name: Create pull request
8989
uses: peter-evans/create-pull-request@v7

‎.github/workflows/update-website.yml‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ jobs:
4343
REF: ${{ github.ref }}
4444
run: |
4545
if [ "${{ github.event_name }}" == "pull_request" ]; then
46-
echo "BRANCH=$REF" >> $GITHUB_OUTPUT
46+
echo "BRANCH=$REF" >> "$GITHUB_OUTPUT"
4747
else
48-
echo 'BRANCH=stable' >> $GITHUB_OUTPUT
48+
echo 'BRANCH=stable' >> "$GITHUB_OUTPUT"
4949
fi
5050
5151
- name: Checkout code
@@ -101,15 +101,15 @@ jobs:
101101
TAG_NAME: ${{ github.event.release.tag_name }}
102102
run: |
103103
if [ "${{ github.event_name }}" == "pull_request" ]; then
104-
echo "REF=$REF_NAME" >> $GITHUB_OUTPUT
105-
echo 'PR_TITLE_PREFIX=[TEST | DO NOT MERGE] ' >> $GITHUB_OUTPUT
106-
echo 'PR_BODY=Test run for the website update after changes to the automated scripts.' >> $GITHUB_OUTPUT
107-
echo 'DRAFT=always-true' >> $GITHUB_OUTPUT
104+
echo "REF=$REF_NAME" >> "$GITHUB_OUTPUT"
105+
echo 'PR_TITLE_PREFIX=[TEST | DO NOT MERGE] ' >> "$GITHUB_OUTPUT"
106+
echo 'PR_BODY=Test run for the website update after changes to the automated scripts.' >> "$GITHUB_OUTPUT"
107+
echo 'DRAFT=always-true' >> "$GITHUB_OUTPUT"
108108
else
109-
echo "REF=$TAG_NAME" >> $GITHUB_OUTPUT
110-
echo 'PR_TITLE_PREFIX=' >> $GITHUB_OUTPUT
111-
echo "PR_BODY=Website update after the release of Requests $TAG_NAME." >> $GITHUB_OUTPUT
112-
echo 'DRAFT=false' >> $GITHUB_OUTPUT
109+
echo "REF=$TAG_NAME" >> "$GITHUB_OUTPUT"
110+
echo 'PR_TITLE_PREFIX=' >> "$GITHUB_OUTPUT"
111+
echo "PR_BODY=Website update after the release of Requests $TAG_NAME." >> "$GITHUB_OUTPUT"
112+
echo 'DRAFT=false' >> "$GITHUB_OUTPUT"
113113
fi
114114
115115
- name: Checkout code

0 commit comments

Comments
 (0)