implement globstar

Author: mlebkowski

composer.json

@@ -9,7 +9,8 @@
         "php-di/php-di": "^6.4",
         "dusank/knapsack": "^10.0",
         "php-di/slim-bridge": "^3.4",
-        "symfony/console": "^5.4"
+        "symfony/console": "^5.4",
+        "symfony/finder": "^5.4"
     },
     "license": "MIT",
     "autoload": {

composer.lock

@@ -5,11 +5,30 @@
 
 use DusanKasan\Knapsack\Collection;
 use RuntimeException;
+use SplFileInfo;
+use Symfony\Component\Finder\Finder;
 
 /** @return string[] */
 function findFiles(string $root, string ...$patterns): iterable {
+    $globstar = '**/';
+
     $root = rtrim($root, '/');
     foreach ($patterns as $pattern) {
+        // php glob does not support globstar to match any directory depth. Let’s hack around it
+        if (str_contains($pattern, $globstar)) {
+            [$directory, $name] = explode($globstar, $pattern, 2);
+            $finder = Finder::create()
+                ->in($root.'/'.ltrim($directory, '/'))
+                ->name($name)
+                ->files()
+                ->sortByName();
+            yield from map(
+                array_values(iterator_to_array($finder)),
+                static fn (SplFileInfo $file) => $file->getRealPath(),
+            );
+            continue;
+        }
+
         $result = glob($root.'/'.ltrim($pattern, '/'));
         if (false === $result) {
             throw new RuntimeException('Invalid pattern: '.$pattern);

src/functions.php

@@ -0,0 +1 @@
+<?php

tests/Resources/ServicesBuilder/alpha.php

@@ -0,0 +1 @@
+<?php

tests/Resources/ServicesBuilder/bravo.php

@@ -0,0 +1 @@
+<?php

tests/Resources/ServicesBuilder/charlie/delta.php

@@ -0,0 +1 @@
+<?php

tests/Resources/ServicesBuilder/charlie/echo/foxtrot.php

@@ -0,0 +1 @@
+{}

tests/Resources/ServicesBuilder/composer.json

@@ -0,0 +1,39 @@
+<?php
+declare(strict_types=1);
+
+namespace WonderNetwork\SlimKernel;
+
+use PHPUnit\Framework\TestCase;
+use function WonderNetwork\SlimKernel\Collection\collection;
+use function WonderNetwork\SlimKernel\Collection\map;
+
+final class ServicesBuilderTest extends TestCase {
+    public function testSimpleGlob(): void {
+        $this->assertFiles('*.php', ['alpha.php', 'bravo.php']);
+    }
+
+    public function testRecursiveGlob(): void {
+        $this->assertFiles(
+            '**/*.php',
+            [
+                'alpha.php',
+                'bravo.php',
+                'charlie/delta.php',
+                'charlie/echo/foxtrot.php',
+            ],
+        );
+    }
+
+    /**
+     * @param string $pattern
+     * @param string[] $expected
+     */
+    private function assertFiles(string $pattern, array $expected): void {
+        $basePath = __DIR__.'/Resources/ServicesBuilder/';
+        $sut = new ServicesBuilder($basePath);
+        $actual = collection($sut->glob($pattern))->toArray();
+        $expected = map($expected, static fn (string $path) => $basePath.$path);
+
+        self::assertSame($expected, $actual);
+    }
+}