[Issue] Selling items via the bot's inventory menu is inconsistent.

[Raz0r1337]

Issue type *

Bug

Addon version

always newest

WoW client version

3.3.5a

Server/AzerothCore version

newest AzerothCore PB Fork

Description *

Selling items via the bot's inventory menu is inconsistent.
Not all items clicked on in the bots' inventories are actually sold.

The chat message indicates that the item has been sold, but when you close and reopen the inventory, the item is still there.

Steps to reproduce

You sell a bunch of items from a bots bag.
Close and reopen the bag of the bot.
Many of them are back in the bag.

Expected behavior *

After selling an item it is gone from the bag.

Actual behavior / Errors

After selling an item it is luck if it is gone.

Crashlog / Gist link (optional)

No response

Screenshots

No response

Pre-submission checklist *

• I searched for existing issues that match mine.
• I tested with the minimum set of addons/changes.
• I provided reproduction steps and/or relevant logs.

Additional context

No response

[Wishmaster117]

Why do you want to force Bots selling items that they not want? :D

I will take a look at that

[Raz0r1337]

I don't think it's the bots that are refusing. 🤣

It seems more like not every click is being executed as a command.

Thx for looking at this.

[Wishmaster117]

Can you try now with my las commit?

[Raz0r1337]

I'm at work now I can test it if I went back home.

[Grimfeather]

just to be clear, you do need to have a vendor selected.

[Raz0r1337]

just to be clear, you do need to have a vendor selected.

I know. 🤣
Of course, I always selected a vendor when selling items from the bots.
Otherwise, I think an error message would appear.

[Raz0r1337]

It seems like the issue is somewhat better with the new commit, but it still occurs very frequently.

[Wishmaster117]

It seems like the issue is somewhat better with the new commit, but it still occurs very frequently.

Is it happening in particular items like stacked items or other specific cases ?

[Raz0r1337]

It affects all items in the bot's inventory (food, drinks, feathers, weapons, armor, and other items). It's not a special circumstance. I simply try to sell items, nothing more. Just fill the bots' bags and try to sell them all one after the other, then reload the inventory. You'll see that a lot of items haven't been sold. Several players have reported this problem to me, and I've noticed it since MultiBot was created. A second and sometimes even a third attempt to sell usually works, but it's unfortunately very annoying. If you'd like, I can walk around with the bots for a while this evening, and when the bags are full, I can make you a video where you can see exactly what's going on. 😉

[Wishmaster117]

It affects all items in the bot's inventory (food, drinks, feathers, weapons, armor, and other items). It's not a special circumstance. I simply try to sell items, nothing more. Just fill the bots' bags and try to sell them all one after the other, then reload the inventory. You'll see that a lot of items haven't been sold. Several players have reported this problem to me, and I've noticed it since MultiBot was created. A second and sometimes even a third attempt to sell usually works, but it's unfortunately very annoying. If you'd like, I can walk around with the bots for a while this evening, and when the bags are full, I can make you a video where you can see exactly what's going on. 😉

Yes please a video will be welcome because i can't reproduce this.

[Raz0r1337]

I'll finish it for you this evening when I get home from work. 😉

It's really strange that you can't reproduce it. Even MacX noticed it, he just didn't have time to look it up. And like I said, a lot of people have asked me the same thing.

If you sell a lot of items one after the other, does it work for you every time?

[Wishmaster117]

@Raz0r1337 I added a refresh functionality to sell function can you test now?

[Raz0r1337]

I have now tested the current build.

It actually works better with the refresh.
The refresh is not performed every time. It refreshes every second or third time I sell items.

And if it's possible, plz turn the sound off that plays when a refresh run.

I couldn't test selling all gray items because I use mod-junk-to-gold, so I have no grey ones.

Selling all items works in principle, but there are still many items left in the bot inventory that can be sold. In my case, about half of the bot inventory is sold.

Before:

After:

Hope that helps.

[Wishmaster117]

@Raz0r1337 have you tried my moded version of mod Junk to Gold? https://github.com/Wishmaster117/mod-junk-to-gold ;)

[Raz0r1337]

No i didnt knew that you have another version, whats the difference?