Skip to content

Commit 3f942d1

Browse files
authored
add option to add connectTimeout in couchbase writer (apache#3958)
1 parent 2a8e3ec commit 3f942d1

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseEnvironmentFactory.java

+2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ public static synchronized CouchbaseEnvironment getInstance(Config config)
4646
String sslTruststorePassword = ConfigUtils.getString(config, CouchbaseWriterConfigurationKeys.SSL_TRUSTSTORE_PASSWORD, "");
4747
Boolean certAuthEnabled = ConfigUtils.getBoolean(config, CouchbaseWriterConfigurationKeys.CERT_AUTH_ENABLED, false);
4848
Boolean dnsSrvEnabled = ConfigUtils.getBoolean(config, CouchbaseWriterConfigurationKeys.DNS_SRV_ENABLED, false);
49+
Long connectTimeout = ConfigUtils.getLong(config, CouchbaseWriterConfigurationKeys.CONNECT_TIMEOUT, CouchbaseWriterConfigurationKeys.CONNECT_TIMEOUT_DEFAULT);
4950
Integer socketConnectTimeout = ConfigUtils.getInt(config, CouchbaseWriterConfigurationKeys.SOCKET_CONNECT_TIMEOUT,
5051
DefaultCouchbaseEnvironment.SOCKET_CONNECT_TIMEOUT);
5152

@@ -56,6 +57,7 @@ public static synchronized CouchbaseEnvironment getInstance(Config config)
5657
.sslTruststoreFile(sslTruststoreFile)
5758
.sslTruststorePassword(sslTruststorePassword)
5859
.certAuthEnabled(certAuthEnabled)
60+
.connectTimeout(connectTimeout)
5961
.dnsSrvEnabled(dnsSrvEnabled)
6062
.socketConnectTimeout(socketConnectTimeout);
6163

gobblin-modules/gobblin-couchbase/src/main/java/org/apache/gobblin/couchbase/writer/CouchbaseWriterConfigurationKeys.java

+3
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ public class CouchbaseWriterConfigurationKeys {
5353

5454
public static final String OPERATION_TIMEOUT_MILLIS = prefix("operationTimeoutMillis");
5555
public static final long OPERATION_TIMEOUT_DEFAULT = 10000; // 10 second default timeout
56+
public static final String CONNECT_TIMEOUT = prefix("connectTimeout");
57+
// using the default value same as DefaultCouchbaseEnvironment.CONNECT_TIMEOUT which is private in java-client-2.7.6
58+
public static final long CONNECT_TIMEOUT_DEFAULT = TimeUnit.SECONDS.toMillis(5);
5659

5760
public static final String RETRIES_ENABLED = prefix("retriesEnabled");
5861
public static final boolean RETRIES_ENABLED_DEFAULT = false;

0 commit comments

Comments
 (0)