Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent error in geometry/huc12_reach_analysis.ipynb #9

Open
xaviernogueira opened this issue Oct 6, 2023 · 0 comments
Open

Fix silent error in geometry/huc12_reach_analysis.ipynb #9

xaviernogueira opened this issue Oct 6, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@xaviernogueira
Copy link
Contributor

Upon learning that HUC12 basins can have multiple COMID outflows, despite having a 1-to-1 outflow relationship with another HUC12.

This means that huc12_reach_analysis.ipynb, which assumes each HUC12 has just one outflow COMID, is silently overwriting any other outflow COMIDs and wrongly populating the "inflow_comids" column of the final dataframe.

@xaviernogueira xaviernogueira added the bug Something isn't working label Oct 6, 2023
@xaviernogueira xaviernogueira self-assigned this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant