improvements

Author: WaterArchery

pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>me.waterarchery</groupId>
     <artifactId>LitLibs</artifactId>
-    <version>1.1.32</version>
+    <version>1.1.33</version>
     <packaging>jar</packaging>
 
     <name>LitLibs</name>
@@ -287,9 +287,9 @@
 
         <!--XSeries for items-->
         <dependency>
-            <groupId>com.github.poyrazinan</groupId>
+            <groupId>com.github.cryptomorin</groupId>
             <artifactId>XSeries</artifactId>
-            <version>3faba3231f</version>
+            <version>13.3.1</version>
         </dependency>
 
         <!--Guis-->

src/main/java/me/waterarchery/litlibs/LitLibsPlugin.java

@@ -26,7 +26,11 @@ public class LitLibsPlugin extends JavaPlugin {
     private BukkitAudiences adventure;;
     private Logger litLogger;
     private BukkitLibraryManager bukkitLibraryManager;
-    private final ExecutorService guiThread = Executors.newSingleThreadExecutor();
+    private final ExecutorService guiThread = Executors.newFixedThreadPool(1, r -> {
+        Thread t = new Thread(r);
+        t.setUncaughtExceptionHandler((thread, throwable) -> throwable.printStackTrace());
+        return t;
+    });
 
     @Override
     public void onLoad() {

src/main/java/me/waterarchery/litlibs/handlers/SoundHandler.java

@@ -28,8 +28,15 @@ public void sendSound(Player p, String configPath, double volume) {
 
     public void sendRawSound(Player p, String soundName, double volume, double pitch) {
         try {
-            XSound xSound = XSound.valueOf(soundName);
-
+            XSound xSound = null;
+            for (XSound sound : XSound.values()) {
+                if (sound.name().equalsIgnoreCase(soundName)) {
+                    xSound = sound;
+                    break;
+                }
+            }
+
+            if (xSound == null) return;
             xSound.play(p, (float) volume, (float) pitch);
         }
         catch (IllegalArgumentException e) {

src/main/java/me/waterarchery/litlibs/libs/ParticleAPI.java

@@ -2,6 +2,7 @@
 
 import me.waterarchery.litlibs.version.Version;
 import me.waterarchery.litlibs.version.VersionHandler;
+import org.bukkit.Color;
 import org.bukkit.Location;
 import org.bukkit.Particle;
 import org.bukkit.entity.Player;
@@ -25,7 +26,13 @@ public static void createParticle(Location location, String particleName) {
         // TODO IMPLEMENT PROPER PARTICLE API
         for (Particle particle : Particle.values()) {
             if (particle.name().equalsIgnoreCase(particleName)) {
-                location.getWorld().spawnParticle(particle, location, 0, 0, 0, 0, 1);
+                if (particle.name().contains("DUST")) {
+                    Particle.DustOptions dustOptions = new Particle.DustOptions(Color.fromARGB(255, 255, 255, 255), 1);
+                    location.getWorld().spawnParticle(particle, location, 0, 0, 0, 0, 1, dustOptions);
+                }
+                else {
+                    location.getWorld().spawnParticle(particle, location, 0, 0, 0, 0, 1);
+                }
                 return;
             }
         }

src/main/java/me/waterarchery/litlibs/listeners/ChunkListeners.java

@@ -29,20 +29,23 @@ public void onNpcLoad(ChunkLoadEvent event) {
         String world = chunk.getWorld().getName();
 
         NPCHandler npcHandler = NPCHandler.getInstance();
-        boolean nullCheck = false;
 
         // Copying array list to preventing the concurrent modification
-        for (NPC npc : new ArrayList<>(npcHandler.getNpcs())) {
-            if (npc == null) {
-                nullCheck = true;
-                continue;
-            }
+        chunkThreadPool.submit(() -> {
+            boolean nullCheck = false;
+
+            for (NPC npc : new ArrayList<>(npcHandler.getNpcs())) {
+                if (npc == null) {
+                    nullCheck = true;
+                    continue;
+                }
 
-            if (!npc.isDespawned()) continue;
-            if (world.equalsIgnoreCase(npc.getWorldName()) && npc.getChunkX() == x && npc.getChunkZ() == z) npc.setDespawned(false);
-        }
+                if (!npc.isDespawned()) continue;
+                if (npc.getChunkX() == x && npc.getChunkZ() == z && world.equals(npc.getWorldName())) npc.setDespawned(false);
+            }
 
-        if (nullCheck) npcHandler.getNpcs().remove(null);
+            if (nullCheck) npcHandler.getNpcs().remove(null);
+        });
     }
 
     @EventHandler (ignoreCancelled = true, priority = EventPriority.HIGHEST)

src/main/resources/plugin.yml

@@ -18,4 +18,5 @@ softdepend:
   - AxGens
   - Citizens
   - FancyNpcs
+  - FancyHolograms
   - RoyaleEconomy