Skip to content

Commit 323d1b9

Browse files
authored
Merge pull request #906 from WatWowMap/fix-motd
fix: motd index setter
2 parents 6b63dba + c4ad276 commit 323d1b9

8 files changed

Lines changed: 36 additions & 29 deletions

File tree

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,4 @@ public/missing-locales
44
public/images/custom
55
public/images/uicons
66
server/src/configs/
7+
packages/types/**/*.d.ts

packages/config/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@
99
"check": "node ./lib/scripts/configCheck.js",
1010
"sort": "npx sort-package-json",
1111
"depCheck": "npx depcheck",
12-
"eslint:check": "eslint \"**/*.{js,jsx}\"",
13-
"eslint:fix": "eslint \"**/*.{js,jsx}\" --fix",
14-
"prettier:check": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
12+
"lint": "eslint \"**/*.{js,jsx}\"",
13+
"lint:fix": "eslint \"**/*.{js,jsx}\" --fix",
14+
"prettier": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
1515
"prettier:fix": "prettier --write \"**/*.{css,html,js,jsx,yml}\""
1616
},
1717
"dependencies": {
1818
"config": "^3.3.9"
1919
}
20-
}
20+
}

packages/locales/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
"missing": "node ./lib/missing.js",
1010
"sort": "npx sort-package-json",
1111
"depCheck": "npx depcheck",
12-
"eslint:check": "eslint \"**/*.{js,jsx}\"",
13-
"eslint:fix": "eslint \"**/*.{js,jsx}\" --fix",
14-
"prettier:check": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
12+
"lint": "eslint \"**/*.{js,jsx}\"",
13+
"lint:fix": "eslint \"**/*.{js,jsx}\" --fix",
14+
"prettier": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
1515
"prettier:fix": "prettier --write \"**/*.{css,html,js,jsx,yml}\""
1616
},
1717
"dependencies": {
@@ -20,4 +20,4 @@
2020
"dotenv": "^16.3.1",
2121
"openai": "^4.24.1"
2222
}
23-
}
23+
}

packages/logger/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66
"scripts": {
77
"sort": "npx sort-package-json",
88
"depCheck": "npx depcheck",
9-
"eslint:check": "eslint \"**/*.{js,jsx}\"",
10-
"eslint:fix": "eslint \"**/*.{js,jsx}\" --fix",
11-
"prettier:check": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
9+
"lint": "eslint \"**/*.{js,jsx}\"",
10+
"lint:fix": "eslint \"**/*.{js,jsx}\" --fix",
11+
"prettier": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
1212
"prettier:fix": "prettier --write \"**/*.{css,html,js,jsx,yml}\""
1313
},
1414
"dependencies": {
1515
"@rm/config": "*",
1616
"chalk": "^4",
1717
"loglevel": "^1.8.1"
1818
}
19-
}
19+
}

packages/masterfile/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
"generate": "node ./lib",
88
"sort": "npx sort-package-json",
99
"depCheck": "npx depcheck",
10-
"eslint:check": "eslint \"**/*.{js,jsx}\"",
11-
"eslint:fix": "eslint \"**/*.{js,jsx}\" --fix",
12-
"prettier:check": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
10+
"lint": "eslint \"**/*.{js,jsx}\"",
11+
"lint:fix": "eslint \"**/*.{js,jsx}\" --fix",
12+
"prettier": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
1313
"prettier:fix": "prettier --write \"**/*.{css,html,js,jsx,yml}\""
1414
},
1515
"dependencies": {
1616
"@rm/config": "*",
1717
"@rm/logger": "*",
1818
"@rm/types": "*"
1919
}
20-
}
20+
}

packages/types/lib/config.d.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import config = require('server/src/configs/default.json')
33
import example = require('server/src/configs/local.example.json')
44

55
import type { Schema } from './server'
6+
import type { DialogProps } from '@mui/material'
67

78
type BaseConfig = typeof config
89
type ExampleConfig = typeof example
@@ -74,13 +75,14 @@ export interface Config<Client extends boolean = false>
7475
messageOfTheDay: {
7576
settings: {
7677
parentStyle: Record<string, string> // should be CSS properties but performance seems to die
77-
} & BaseConfig['map']['messageOfTheDay']['settings']
78+
} & Omit<BaseConfig['map']['messageOfTheDay']['settings'], 'parentStyle'>
7879
titles: string[]
7980
components: CustomComponent[]
8081
footerButtons: CustomComponent[]
82+
dialogMaxWidth: DialogProps['maxWidth']
8183
} & Omit<
8284
BaseConfig['map']['messageOfTheDay'],
83-
'settings' | 'titles' | 'components' | 'footerButtons'
85+
'settings' | 'titles' | 'components' | 'footerButtons' | 'dialogMaxWidth'
8486
>
8587
donationPage: {
8688
settings: {
@@ -145,6 +147,7 @@ export interface Webhook {
145147
}
146148

147149
export interface CustomComponent {
150+
type?: string
148151
components?: CustomComponent[]
149152
donorOnly?: boolean
150153
freeloaderOnly?: boolean

packages/types/package.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,14 @@
66
"scripts": {
77
"sort": "npx sort-package-json",
88
"depCheck": "npx depcheck",
9-
"eslint:check": "eslint \"**/*.{js,jsx}\"",
10-
"eslint:fix": "eslint \"**/*.{js,jsx}\" --fix",
11-
"prettier:check": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
9+
"lint": "eslint \"**/*.{js,jsx}\"",
10+
"lint:fix": "eslint \"**/*.{js,jsx}\" --fix",
11+
"prettier": "prettier --check \"**/*.{css,html,js,jsx,yml}\"",
1212
"prettier:fix": "prettier --write \"**/*.{css,html,js,jsx,yml}\""
1313
},
1414
"devDependencies": {
1515
"@apollo/client": "^3.7.15",
16+
"@mui/material": "^5.14.0",
1617
"@sentry/node": "^7.48.0",
1718
"@types/config": "^3.3.0",
1819
"@types/node": "^20.5.1",
@@ -26,4 +27,4 @@
2627
"passport-discord": "https://github.com/tonestrike/passport-discord.git",
2728
"passport-oauth2": "^1.7.0"
2829
}
29-
}
30+
}

src/components/layout/dialogs/Motd.jsx

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@ import DialogWrapper from '../custom/DialogWrapper'
1414
import CustomTile from '../custom/CustomTile'
1515
import { Loading } from '../general/Loading'
1616

17-
const DEFAULT = {
18-
settings: {},
19-
components: [],
20-
titles: [],
21-
footerButtons: [],
22-
}
17+
const DEFAULT =
18+
/** @type {import('@rm/types').Config['map']['messageOfTheDay']} */ ({
19+
settings: {},
20+
components: [],
21+
titles: [],
22+
footerButtons: [],
23+
index: 0,
24+
})
2325

2426
export default function MessageOfTheDay() {
2527
const clientIndex = useStore((s) => s.motdIndex)
@@ -42,7 +44,7 @@ export default function MessageOfTheDay() {
4244

4345
const handleMotdClose = React.useCallback(() => {
4446
if (motd.settings.permanent === false) {
45-
useStore.setState({ motdIndex: motd.settings.index })
47+
useStore.setState({ motdIndex: motd.index })
4648
}
4749
useLayoutStore.setState({ motd: false })
4850
}, [motd])

0 commit comments

Comments
 (0)