MAINT: Avoid type punning by copying (grrr...)

WarrenWeckesser · WarrenWeckesser · commit 6aeec11449fa · 2024-06-28T08:58:45.000-04:00
diff --git a/src/vnorm/vnorm_gufunc.h b/src/vnorm/vnorm_gufunc.h
@@ -22,19 +22,22 @@
 static inline float
 my_cabs(npy_cfloat z)
 {
-    return std::abs(*(reinterpret_cast<std::complex<float> *>(&z)));
+    std::complex<float> zs{npy_crealf(z), npy_cimagf(z)};
+    return std::abs(zs);
 }
 
 static inline double
 my_cabs(npy_cdouble z)
 {
-    return std::abs(*(reinterpret_cast<std::complex<double> *>(&z)));
+    std::complex<double> zs{npy_creal(z), npy_cimag(z)};
+    return std::abs(zs);
 }
 
 static inline long double
 my_cabs(npy_clongdouble z)
 {
-    return std::abs(*(reinterpret_cast<std::complex<long double> *>(&z)));
+    std::complex<long double> zs{npy_creall(z), npy_cimagl(z)};
+    return std::abs(zs);
 }
 
 //

Original file line number	Diff line number	Diff line change
`@@ -22,19 +22,22 @@`
`22`	`22`	`static inline float`
`23`	`23`	`my_cabs(npy_cfloat z)`
`24`	`24`	`{`
`25`		`- return std::abs((reinterpret_cast<std::complex<float> >(&z)));`
	`25`	`+ std::complex<float> zs{npy_crealf(z), npy_cimagf(z)};`
	`26`	`+ return std::abs(zs);`
`26`	`27`	`}`
`27`	`28`
`28`	`29`	`static inline double`
`29`	`30`	`my_cabs(npy_cdouble z)`
`30`	`31`	`{`
`31`		`- return std::abs((reinterpret_cast<std::complex<double> >(&z)));`
	`32`	`+ std::complex<double> zs{npy_creal(z), npy_cimag(z)};`
	`33`	`+ return std::abs(zs);`
`32`	`34`	`}`
`33`	`35`
`34`	`36`	`static inline long double`
`35`	`37`	`my_cabs(npy_clongdouble z)`
`36`	`38`	`{`
`37`		`- return std::abs((reinterpret_cast<std::complex<long double> >(&z)));`
	`39`	`+ std::complex<long double> zs{npy_creall(z), npy_cimagl(z)};`
	`40`	`+ return std::abs(zs);`
`38`	`41`	`}`
`39`	`42`
`40`	`43`	`//`