Skip to content

Commit ae1465c

Browse files
committed
update NOTES
1 parent 27d28ee commit ae1465c

6 files changed

Lines changed: 15 additions & 18 deletions

File tree

.Rbuildignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,4 @@
2929
^\.fresh$
3030
^\.vscode$
3131
^CRAN-SUBMISSION$
32+
^tmp\.R$

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,4 @@
88
docs
99
.codebuddy/skills/mirai/SKILL.md
1010
CRAN-SUBMISSION
11+
tmp*

README.Rmd

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
[![Lifecycle:stable](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html#stable)
55
[![Project Status: Active - The project has reached a stable, usable state and is being actively developed.](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active)
66
[![CRAN status](https://www.r-pkg.org/badges/version/rpkgkit)](https://CRAN.R-project.org/package=rpkgkit)
7-
[![r-universe status badge](https://WangLabCSU.r-universe.dev/badges/rpkgkit)](https://WangLabCSU.r-universe.dev/rpkgkit)
87
[![R-CMD-check](https://github.com/WangLabCSU/rpkgkit/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/WangLabCSU/rpkgkit/actions/workflows/R-CMD-check.yaml)
98
[![Devel version](https://img.shields.io/badge/devel%20version-0.0.7-blue.svg)](https://github.com/WangLabCSU/rpkgkit)
109
[![Code size](https://img.shields.io/github/languages/code-size/WangLabCSU/rpkgkit.svg)](https://github.com/WangLabCSU/rpkgkit)
@@ -317,7 +316,7 @@ msg <- glue::glue("Hello, {name!")
317316
library(cli)
318317
warning <- ""
319318
bar <- cli::col_red(cli::cli_alert_warning(
320-
"{.field warning}}: This string is missing {.val 2} brace{?s}"
319+
"{.field warning}}: This string is missing {.val 1} brace{?s}"
321320
))
322321
```
323322

@@ -327,7 +326,7 @@ detect_lost_glue_brace()
327326
# msg <- glue::glue("Hello, {name!")
328327
# ^^^^^^
329328

330-
# "{.field warning}}: This string is missing {.val 2} brace{?s}"
329+
# "{.field warning}}: This string is missing {.val 1} brace{?s}"
331330
# ^^^^^^^^^^^^^^^^^
332331
# ✖ Found 2 lines with mismatched braces: 3 and 8
333332
```

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
[![Lifecycle:stable](https://img.shields.io/badge/lifecycle-stable-brightgreen.svg)](https://lifecycle.r-lib.org/articles/stages.html#stable)
55
[![Project Status: Active - The project has reached a stable, usable state and is being actively developed.](https://www.repostatus.org/badges/latest/active.svg)](https://www.repostatus.org/#active)
66
[![CRAN status](https://www.r-pkg.org/badges/version/rpkgkit)](https://CRAN.R-project.org/package=rpkgkit)
7-
[![r-universe status badge](https://WangLabCSU.r-universe.dev/badges/rpkgkit)](https://WangLabCSU.r-universe.dev/rpkgkit)
87
[![R-CMD-check](https://github.com/WangLabCSU/rpkgkit/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/WangLabCSU/rpkgkit/actions/workflows/R-CMD-check.yaml)
98
[![Devel version](https://img.shields.io/badge/devel%20version-0.0.7-blue.svg)](https://github.com/WangLabCSU/rpkgkit)
109
[![Code size](https://img.shields.io/github/languages/code-size/WangLabCSU/rpkgkit.svg)](https://github.com/WangLabCSU/rpkgkit)
@@ -317,7 +316,7 @@ msg <- glue::glue("Hello, {name!")
317316
library(cli)
318317
warning <- ""
319318
bar <- cli::col_red(cli::cli_alert_warning(
320-
"{.field warning}}: This string is missing {.val 2} brace{?s}"
319+
"{.field warning}}: This string is missing {.val 1} brace{?s}"
321320
))
322321
```
323322

@@ -327,7 +326,7 @@ detect_lost_glue_brace()
327326
# msg <- glue::glue("Hello, {name!")
328327
# ^^^^^^
329328

330-
# "{.field warning}}: This string is missing {.val 2} brace{?s}"
329+
# "{.field warning}}: This string is missing {.val 1} brace{?s}"
331330
# ^^^^^^^^^^^^^^^^^
332331
# ✖ Found 2 lines with mismatched braces: 3 and 8
333332
```

cran-comments.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## R CMD check results
22

3-
0 errors | 0 warnings | 1 note
3+
0 errors | 0 warnings | 2 notes
44

55
* This is a new submission.
66

@@ -9,6 +9,14 @@
99
* The NOTE "New submission" is expected for first-time CRAN submissions and will be
1010
resolved once the package is accepted.
1111

12+
* NOTE about `pedant` package dependency: This package uses `pedant` (GitHub only,
13+
`wurli/pedant`) in the `make_func_call_explicit()` function for adding double-colon
14+
prefixes to function calls. To comply with CRAN policy, `Remotes` is not declared in
15+
DESCRIPTION, and `pedant` is listed only in `Suggests` (not `Imports`). In practice,
16+
we provide a runtime check similar to `rlang::check_installed()`: when
17+
`make_func_call_explicit()` is called without `pedant` installed, the user is prompted
18+
to install it interactively via `pak::pkg_install("wurli/pedant")`.
19+
1220
## Reverse Dependencies
1321

1422
There are no reverse dependencies.

tests/testthat/test-make_func_call_explicit.R

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,3 @@
1-
test_that("make_func_call_explicit aborts when path is provided explicitly", {
2-
expect_error(
3-
make_func_call_explicit(
4-
path = "test.R",
5-
use_packages = "dplyr",
6-
ignore_functions = "library"
7-
),
8-
"is required"
9-
)
10-
})
11-
121
test_that("make_func_call_explicit reads file, adds colons, and writes back", {
132
mock_path <- "/mock/project/R/my_file.R"
143
mock_input_code <- paste(

0 commit comments

Comments
 (0)