Merge pull request #116 from BaderSerhan/fix/cancelUpload

StevePotter · web-flow · commit f098d0c7bdd7 · 2019-01-03T11:57:59.000-05:00
fix cancelUpload not working
diff --git a/ios/VydiaRNFileUploader.m b/ios/VydiaRNFileUploader.m
@@ -226,7 +226,8 @@ - (void)copyAssetToFile: (NSString *)assetUrl completionHandler: (void(^)(NSStri
 RCT_EXPORT_METHOD(cancelUpload: (NSString *)cancelUploadId resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {
     [_urlSession getTasksWithCompletionHandler:^(NSArray *dataTasks, NSArray *uploadTasks, NSArray *downloadTasks) {
         for (NSURLSessionTask *uploadTask in uploadTasks) {
-            if (uploadTask.taskDescription == cancelUploadId) {
+            if ([uploadTask.taskDescription isEqualToString:cancelUploadId]){
+                // == checks if references are equal, while isEqualToString checks the string value
                 [uploadTask cancel];
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -226,7 +226,8 @@ - (void)copyAssetToFile: (NSString *)assetUrl completionHandler: (void(^)(NSStri`
`226`	`226`	`RCT_EXPORT_METHOD(cancelUpload: (NSString *)cancelUploadId resolve:(RCTPromiseResolveBlock)resolve reject:(RCTPromiseRejectBlock)reject) {`
`227`	`227`	`[_urlSession getTasksWithCompletionHandler:^(NSArray dataTasks, NSArray uploadTasks, NSArray *downloadTasks) {`
`228`	`228`	`for (NSURLSessionTask *uploadTask in uploadTasks) {`
`229`		`- if (uploadTask.taskDescription == cancelUploadId) {`
	`229`	`+ if ([uploadTask.taskDescription isEqualToString:cancelUploadId]){`
	`230`	`+ // == checks if references are equal, while isEqualToString checks the string value`
`230`	`231`	`[uploadTask cancel];`
`231`	`232`	`}`
`232`	`233`	`}`