New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle arabic short week days #1088

Open

lmetdaoui wants to merge 1 commit into Vuepic:main from lmetdaoui:main

lmetdaoui commented Mar 4, 2025 •

edited

Loading

Describe your changes

When using ar as locale, week days' short names were identical because we would always slice the full day names on indexes 0 to 2 to format them.

I made an exception for arabic, slicing the weekdays on indexes 2 to 5

This is how it looks like now:

Before	After

Issue ticket number and link

Fixes #1087

Checklist before requesting a review

I have performed a self-review of my code
I have ensured that unit tests pass without errors
If it is a new feature, I have added a new unit test


          fix: handle arabic short week days

5ef0b0c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet