Fix: add version number to ci workflow

Author: GideonBature

.github/workflows/test.yml

@@ -2,9 +2,9 @@ name: Test CI
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
   test:
@@ -30,18 +30,18 @@ jobs:
         uses: actions/checkout@v3
 
       - name: Set up Node.js
-        uses: actions/setup-node@v
+        uses: actions/setup-node@v4
         with:
-          node-version: '18'
-          cache: 'npm'
+          node-version: "18"
+          cache: "npm"
 
       - name: Install dependencies
         run: npm ci
 
       - name: Build Docker image
         run: |
-            docker build -t volunchain-backend .
-            docker run -d --name volunchain_test --link postgres:db -e DATABASE_URL=postgresql://volunchain:volunchain123@db:5432/volunchain_test volunchain-backend
+          docker build -t volunchain-backend .
+          docker run -d --name volunchain_test --link postgres:db -e DATABASE_URL=postgresql://volunchain:volunchain123@db:5432/volunchain_test volunchain-backend
 
       - name: Generate Prisma Client
         run: npx prisma generate
@@ -72,4 +72,4 @@ jobs:
         if: always()
         run: |
           docker stop volunchain_test
-          docker rm volunchain_test    
+          docker rm volunchain_test

src/modules/user/__tests__/controllers/UserController.int.test.ts

@@ -8,17 +8,20 @@ jest.mock("../../../../services/UserService");
 import { UserService } from "../../../../services/UserService";
 
 // Mock DTOs
-jest.mock("../../../../modules/user/dto/CreateUserDto", () => {
+jest.mock("../../dto/CreateUserDto", () => {
   return {
-    CreateUserDto: function () {
-      return {};
+    CreateUserDto: function (data: Record<string, unknown>) {
+      // Mock validation logic
+      if (!data.email) throw new Error("Email is required");
+      return { email: data.email, ...data };
     },
   };
 });
-jest.mock("../../../../modules/user/dto/UpdateUserDto", () => {
+jest.mock("../../dto/UpdateUserDto", () => {
   return {
-    UpdateUserDto: function () {
-      return {};
+    UpdateUserDto: function (data: Record<string, unknown>) {
+      // Mock basic validation similar to CreateUserDto
+      return { ...data };
     },
   };
 });
@@ -34,6 +37,10 @@ function setupApp(): Express {
   return app;
 }
 
+const setupMockUserService = (methods: Partial<Record<string, unknown>>) => {
+  (UserService as jest.Mock).mockImplementation(() => methods);
+};
+
 describe("UserController", () => {
   let app: Express;
 
@@ -45,9 +52,9 @@ describe("UserController", () => {
   describe("POST /users", () => {
     it("should create a user and return 201", async () => {
       const mockUser = { id: "1", email: "[email protected]" };
-      (UserService as jest.Mock).mockImplementation(() => ({
+      setupMockUserService({
         createUser: jest.fn().mockResolvedValue(mockUser),
-      }));
+      });
       const res = await request(app)
         .post("/users")
         .send({ email: "[email protected]" });
@@ -65,6 +72,19 @@ describe("UserController", () => {
       expect(res.status).toBe(400);
       expect(res.body.error).toBe("fail");
     });
+
+    it("should handle validation errors with specific status codes", async () => {
+      (UserService as jest.Mock).mockImplementation(() => ({
+        createUser: jest
+          .fn()
+          .mockRejectedValue(new Error("Invalid email format")),
+      }));
+      const res = await request(app)
+        .post("/users")
+        .send({ email: "invalid-email" });
+      expect(res.status).toBe(422);
+      expect(res.body.error).toContain("Ivalid email format");
+    });
   });
 
   describe("GET /users/:id", () => {