Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable rules_JavaRulesUpdateTest.kt #411

Open
vorburger opened this issue Mar 3, 2025 · 1 comment
Open

Unstable rules_JavaRulesUpdateTest.kt #411

vorburger opened this issue Mar 3, 2025 · 1 comment

Comments

@vorburger
Copy link
Contributor

vorburger commented Mar 3, 2025

#409, which is just a very minor docs change, failed with:

//e2e/src/test/kotlin/org/virtuslab/bazelsteward/e2e/rules/heuristic:heuristic_HeuristicUpdateVariables2Test.kt PASSED in 19.7s
//e2e/src/test/kotlin/org/virtuslab/bazelsteward/e2e/rules/heuristic:heuristic_HeuristicUpdateVariablesTest.kt PASSED in 20.4s
//e2e/src/test/kotlin/org/virtuslab/bazelsteward/e2e/rules:rules_JavaRulesUpdateTest.kt TIMEOUT in 60.3s
  /home/runner/.cache/bazel/_bazel_runner/485917b46683ef4511aba2a18731dd56/execroot/bazel-steward/bazel-out/k8-fastbuild/testlogs/e2e/src/test/kotlin/org/virtuslab/bazelsteward/e2e/rules/rules_JavaRulesUpdateTest.kt/test.log

As that was a docs-only PR unrelated to that test, this smells like a case of a flaky / unstable test.

Just wanted to let you know.

@lukaszwawrzyk
Copy link
Collaborator

Thanks for heads up :) This is a known issue in this repo which appears in case of intense development ;) GITHUB_TOKEN is used to query for various rules updates and with so many tests it is easy to exhaust quota. I just tend to ignore these timeouts in rules tests if other things pass.
When bzlmod will fully replace WORKSPACE files with bazel 9, we will be just able to remove this update method at all and thus these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants