Repository navigation
feat(Mersenne31): prove circle coset validity and cardinality - #415
alexanderlhicks merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🤖 PR SummaryMathematical Formalization
Documentation
Testing
Structure: The core mathematical substance is concentrated in Statistics
Lean Declarations ✏️ Added: 41 declaration(s)
📋 **Additional Analysis**Style and Naming
Documentation
Tests
Code Style and Formatting
Validation Commands
SummaryOverall, the diff is well-structured and follows the project’s guidelines. The two minor issues are the naming of 📄 **Per-File Summaries**
Last updated: 2026-11-18 00:24 UTC. |
Summary
Follow-up to #310. Prove that circle indices represent distinct points and that valid cosets enumerate exactly their declared number of points.
CirclePointIndex.toPoint_injective, preservation of additive order, and the exact order2^nofsubgroupGen n h, including log sizes 0 and 31.Coset.Validby equality of the step's additive order and the declared size. Prove validity for the standard constructors and canonical full and half cosets, and preservation under conjugation.The tests include a zero-step size-two coset that is not valid and a valid singleton half coset that overlaps its conjugate. Coset validity alone does not imply circle-domain validity. Disjointness of domain halves and circle-domain cardinality remain separate follow-up work.
Validation
lake build --wfaillake testlake exe axiomsweep --check: 11,145 declarations across 401 modules; zerosorryAx-tainted or non-standard-axiom-tainted declarations../scripts/lint-style.sh./scripts/check-imports.shuv run --no-project --python 3.12 python scripts/check-docs-integrity.pyuv run --no-project --python 3.12 python scripts/check-writing.py --base e28da34git diff --checkAll checks passed locally on Lean 4.35.0. No runtime implementations or existing structure fields change.