Skip to content

ci(bench): skip PR comment writes on fork runs - #397

Merged
dhsorens merged 2 commits into
Verified-zkEVM:mainfrom
mitschabaude-bot:fix-benchmark-fork-comments
Oct 20, 2026
Merged

dhsorens merged 2 commits into
Verified-zkEVM:mainfrom
mitschabaude-bot:fix-benchmark-fork-comments

Conversation

@mitschabaude-bot

Copy link
Copy Markdown
Contributor

Summary

Skip the benchmark comment-writing step for fork pull_request runs, whose GitHub token is read-only. Reports remain available in the Actions summary and downloadable artifacts. Same-repository PR runs and authorized /bench comment runs retain comment posting.

This fixes the only failing step on #389, #391 and #392: their benchmarks and artifact uploads succeeded, but Upsert benchmark PR comment returned HTTP 403 (Resource not accessible by integration).

Only the comment step condition changes; this PR contains no other CI or benchmark changes.

Validation

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 PR Summary

Infrastructure / CI

  • Change – In .github/workflows/benchmarks.yml, the if condition on the "Upsert benchmark PR comment" step was augmented with github.event.pull_request.head.repo.full_name == github.repository. This skips comment posting when the benchmark runs on a pull request from a forked repository.
  • Rationale – Fork PRs use a read-only GitHub token, causing the step to fail with HTTP 403 (Resource not accessible by integration). The change prevents that failure while preserving all other functionality.
  • What is not affected – Benchmark execution, artifact upload, and the overall CI report remain fully available in the Actions summary and via downloadable artifacts. Same-repository PR runs and responses to authorized /bench comments continue to post the comment.
  • Scope – This is the only modification in the PR; no other CI jobs, scripts, or library code are changed.
  • Verification – The same guard pattern has already passed on fork PR perf(ntt): proved parallel KoalaBear NTTs against Plonky3 #395. actionlint and git diff --check pass.
  • No placeholders – No sorry, admit, or other stubs are introduced. The change is purely CI logic and involves no code that could contain such placeholders.

Statistics

Metric Count
📝 Files Changed 1
✅ Lines Added 6
❌ Lines Removed 1

Lean Declarations

  • No declarations were added, removed, or affected.

sorry Tracking

  • No sorrys were added, removed, or affected.

📋 **Additional Analysis**

The diff only changes a CI workflow guard that gates whether a benchmark PR comment is written. It does not touch any Lean source files, tests, documentation under docs/wiki/, blueprint/, bench/, or any other area covered by the instructions. All instructions are irrelevant to this change.


📄 **Per-File Summaries**
  • .github/workflows/benchmarks.yml: The if condition for the "Upsert benchmark PR comment" step was extended to skip execution on pull requests originating from forked repositories (github.event.pull_request.head.repo.full_name == github.repository check). This avoids workflow failures caused by read-only tokens on fork PRs; the benchmark report is still available through the Actions summary and artifact.

Last updated: 2026-10-20 10:16 UTC.

@dhsorens

Copy link
Copy Markdown
Collaborator

lgtm

@dhsorens
dhsorens enabled auto-merge (squash) October 20, 2026 10:16
@dhsorens
dhsorens merged commit 5faf2cb into Verified-zkEVM:main Oct 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants