Repository navigation
ci(bench): skip PR comment writes on fork runs - #397
Merged
dhsorens merged 2 commits intoOct 20, 2026
Merged
Conversation
Contributor
🤖 PR SummaryInfrastructure / CI
Statistics
Lean Declarations
📋 **Additional Analysis**The diff only changes a CI workflow guard that gates whether a benchmark PR comment is written. It does not touch any Lean source files, tests, documentation under 📄 **Per-File Summaries**
Last updated: 2026-10-20 10:16 UTC. |
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip the benchmark comment-writing step for fork
pull_requestruns, whose GitHub token is read-only. Reports remain available in the Actions summary and downloadable artifacts. Same-repository PR runs and authorized/benchcomment runs retain comment posting.This fixes the only failing step on #389, #391 and #392: their benchmarks and artifact uploads succeeded, but
Upsert benchmark PR commentreturned HTTP 403 (Resource not accessible by integration).Only the comment step condition changes; this PR contains no other CI or benchmark changes.
Validation
actionlint -shellcheck= -pyflakes= .github/workflows/benchmarks.ymlpasses.git diff --checkpasses.