Conversation
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| const search = constructSearchString<{ degenMode?: boolean }>({ | ||
| degenMode, | ||
| }); | ||
| const fetchURL = `${postOrderUrl}/${search}` as const; |
There was a problem hiding this comment.
Trailing slash changes POST URL for all orders
High Severity
The URL template `${postOrderUrl}/${search}` introduces a spurious / between the path and the query string. When degenMode is not provided (the common case), constructSearchString returns "", so the URL becomes …/delta/orders/ instead of the previous …/delta/orders. When degenMode is provided, it becomes …/delta/orders/?degenMode=true instead of …/delta/orders?degenMode=true. This is a regression for every postDeltaOrder call. The existing test expects the URL without a trailing slash. The sibling getDeltaOrders uses ${baseUrl}${search} (no extra /) for the same endpoint.
There was a problem hiding this comment.
Sometimes we do /search, sometimes without /. We should decide on one way
| const search = constructSearchString<{ degenMode?: boolean }>({ | ||
| degenMode, | ||
| }); | ||
| const fetchURL = `${postOrderUrl}/${search}` as const; |
There was a problem hiding this comment.
Sometimes we do /search, sometimes without /. We should decide on one way
| /** @description SELL or BUY, default is SELL */ | ||
| side?: SwapSideUnion; | ||
| /** @description In %. It's a way to bypass the API price impact check (default = 15%) */ | ||
| maxImpact?: number; |
There was a problem hiding this comment.
Could you also add maxUSDImpact. It's present in other price endpoints
…pdate-bridgePrice
Feat/update bridge price
2 participants
Accepts
degenModeparam for:Note
Medium Risk
Mostly additive optional query parameters, but it changes URL construction for
getDeltaPriceandpostDeltaOrder, which could break API calls if the path/query separator is incorrect.Overview
Adds optional
degenModesupport across the SDK’s swap and Delta flows, threading it through rate queries (/prices), transaction building (/transactions), Delta price queries (/delta/prices), and Delta order submission (/delta/orders).Also extends Delta price request/response typing (e.g.,
maxImpact,maxUSDImpact, and BUY-sidesrc*BeforeFeefields inAvailableBridge) and adjusts URL construction for Delta price fetching and Delta order posting to incorporate query strings.Written by Cursor Bugbot for commit 897a206. This will update automatically on new commits. Configure here.