[KernelCache] Pass the correct flags when adding an image's segments

bdash · bdash · commit cf2285ca6c15 · 2025-09-05T21:41:21.000-07:00
Fixes #7354.
diff --git a/view/kernelcache/core/KernelCacheController.cpp b/view/kernelcache/core/KernelCacheController.cpp
@@ -124,7 +124,8 @@ bool KernelCacheController::ApplyImage(BinaryView& view, const CacheImage& image
 		loadedRegion = true;
 		for (const auto& segment : image.header->segments)
 		{
-			view.AddAutoSegment(segment.vmaddr, segment.vmsize, segment.fileoff, segment.filesize, segment.flags);
+			auto flags = SegmentFlagsFromMachOProtections(segment.initprot, segment.maxprot);
+			view.AddAutoSegment(segment.vmaddr, segment.vmsize, segment.fileoff, segment.filesize, flags);
 
 			auto relocations = m_cache.GetRelocations();
 

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,8 @@ bool KernelCacheController::ApplyImage(BinaryView& view, const CacheImage& image`
`124`	`124`	`loadedRegion = true;`
`125`	`125`	`for (const auto& segment : image.header->segments)`
`126`	`126`	`{`
`127`		`- view.AddAutoSegment(segment.vmaddr, segment.vmsize, segment.fileoff, segment.filesize, segment.flags);`
	`127`	`+ auto flags = SegmentFlagsFromMachOProtections(segment.initprot, segment.maxprot);`
	`128`	`+ view.AddAutoSegment(segment.vmaddr, segment.vmsize, segment.fileoff, segment.filesize, flags);`
`128`	`129`
`129`	`130`	`auto relocations = m_cache.GetRelocations();`
`130`	`131`