Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the ltrb calculation inconsistent with the paper? #19

Open
saojianjian opened this issue Apr 6, 2021 · 3 comments
Open

Is the ltrb calculation inconsistent with the paper? #19

saojianjian opened this issue Apr 6, 2021 · 3 comments

Comments

@saojianjian
Copy link

I found that the calculation of ltrb in the code was inconsistent with that in the paper, line 102 and line 104 of the model/loss.py file
image1
What ltrb means in the paper is
image2
I think the correct calculation code should be
image3

Please let me know if there is an error in my understanding.
Thank you!

@VectXmy
Copy link
Owner

VectXmy commented Apr 6, 2021

你可以试着按照你那样的计算方式算一下看看,b_off和t_off会变成负值

@saojianjian
Copy link
Author

你可以试着按照你那样的计算方式算一下看看,b_off和t_off会变成负值

想请教一下,你在复现代码的时候有看论文作者在他的代码里是这么实现的吗?
我看你DetectHead里的_coords2boxes是按照你GenTargets里_gen_level_targets函数的ltrb的实现方式解析回原图坐标的,逻辑上没什么问题。如果要改代码的话,得把这一处也给改了

@VectXmy
Copy link
Owner

VectXmy commented Apr 7, 2021

不懂你想说啥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants