Skip to content

Conversation

@Krzmbrzl
Copy link
Collaborator

@Krzmbrzl Krzmbrzl commented Dec 8, 2025

Note: I didn't add overloads for +=, -= and friends for now. They could be added once we have a need for them…

/CC @ajay-mk: these should allow you to shorten your expressions in the manuscript

Copy link
Member

@ajay-mk ajay-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Krzmbrzl.

Just one question: why change from std::constructible_from to std::is_constructible_v?

PS: I did not mean to request changes, mouse slip :(

@Krzmbrzl
Copy link
Collaborator Author

Krzmbrzl commented Dec 8, 2025

Just one question: why change from std::constructible_from to std::is_constructible_v?

That wasn't intentional. Looking at the docs, these should be functionally equivalent though 👀

@ajay-mk
Copy link
Member

ajay-mk commented Dec 8, 2025

That wasn't intentional. Looking at the docs, these should be functionally equivalent though 👀

That's what I thought. I was just wondering if there’s any difference.

@Krzmbrzl Krzmbrzl force-pushed the arithmetic-operators-for-numeric-types branch from d13037a to a8415b8 Compare December 9, 2025 09:26
@Krzmbrzl Krzmbrzl merged commit fc1f6cf into ValeevGroup:master Dec 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants