Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Синхронизировать API у ModalCard и ModalPage #8216

Open
BlackySoul opened this issue Jan 30, 2025 · 1 comment
Open

[Feature]: Синхронизировать API у ModalCard и ModalPage #8216

BlackySoul opened this issue Jan 30, 2025 · 1 comment
Labels
cmp:modal cmp:modal-card cmp:modal-page type:enhancement
Milestone
v8.0.0

Comments

@BlackySoul
Copy link
Contributor

Описание

Необходимо пройтись по API ModalCard и ModalPage и синхронизировать свойства.
Например, для лейбла кнопки закрытия пропы modalDismissButtonLabel и dismissLabel. Возможно, как-то получится унифицировать ещё и hideCloseButton и dismissButtonMode

Скриншоты

No response
@BlackySoul BlackySoul added this to the v8.0.0 milestone Jan 30, 2025
@BlackySoul BlackySoul added this to VKUI Jan 30, 2025
@github-project-automation github-project-automation bot moved this to 🗃 Backlog in VKUI Jan 30, 2025
@inomdzhon
Copy link
Contributor

Можно и в рамках v7 через депрекейт старого API

@inomdzhon inomdzhon mentioned this issue Feb 11, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmp:modal cmp:modal-card cmp:modal-page type:enhancement
Projects
VKUI
Status: 🗃 Backlog
Milestone
v8.0.0
Development

No branches or pull requests
2 participants
@inomdzhon @BlackySoul