Skip to content

Validation is too aggressive #20

@WillStrohl

Description

@WillStrohl

Sponsorship

If this request requires additional support (e.g., such as direct email/phone/meeting/development), I have the following interest in helping to sponsor the effort via GitHub Sponsors:

  • None, please continue to work for me for free :P
  • Absolutely, I get value out of this!
  • Maybe later
  • I'm already a sponsor... Woot!

Describe the bug

When you intend to save the app settings, it attempts to validate the settings as you'd expect, but also the image path. The settings won't save.

Software Versions

  • DNN: 09.13.01
  • Module: 01.00.00

To Reproduce

Steps to reproduce the behavior:

  1. Install the module and add it to a page.
  2. Attempt to add valid settings to the app settings area.
  3. Click to save the settings.

Expected behavior

The settings are saved. No other fields are validated. Visual feedback appears to let us know the settings were saved.

Actual behavior

Not sure if the settings were saved or not when this happens. The image path field is throwing an error that is' required. That is a different button that should be validating the image path.

While troubleshooting, I can confirm that the settings are saved, but it's not obvious when you're using the module.

Screenshots

image

Error log

Nothing to report.

Additional context

None at this time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Sponsors WelcomeActively accepting sponsors for this taskbugSomething isn't workingenhancementNew feature or requestgood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions