Skip to content

[Bug]: FulfillmentTest.test_new_user_new_address_persistence logic is flawed #18

@semenovm

Description

@semenovm

What happened?

This bug/disscussion request.

FulfillmentTest.test_new_user_new_address_persistence verifies that new address is persisted between two different checkout sessions.

There is a couple issues with it:

  1. It is out of scope of the protocol. Documentation doesn't specify any requirements for such interaction. It is a decision of business how they handle personal data.

  2. Current implementation expect the new address available in the new checkout, before original checkout is even completed. This doesn't look like a good practice, as it might cause saving incomplete/incorrect temporary state and polut the database and borderline gathering PII without consent.

I propose to drop the test case completely.

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions