Rider suggestions (#4778)

* more tests

* more suggestions

* more cleanup

* more imporvements

* fix compile error

Co-authored-by: Ruo-Ping Dong <[email protected]>

Author: Chris Elion

Project/Assets/ML-Agents/Examples/3DBall/Scripts/Ball3DAgent.cs

@@ -1,4 +1,3 @@
-using System;
 using UnityEngine;
 using Unity.MLAgents;
 using Unity.MLAgents.Actuators;

Project/Assets/ML-Agents/Examples/Basic/Scripts/BasicController.cs

@@ -1,7 +1,6 @@
 using UnityEngine;
 using UnityEngine.SceneManagement;
 using Unity.MLAgents;
-using Unity.MLAgents.Actuators;
 using UnityEngine.Serialization;
 
 /// <summary>

Project/Assets/ML-Agents/Examples/Crawler/Scripts/CrawlerAgent.cs

@@ -1,4 +1,3 @@
-using System;
 using UnityEngine;
 using Unity.MLAgents;
 using Unity.Barracuda;
@@ -334,14 +333,14 @@ Vector3 GetAvgVelocity()
         Vector3 avgVel = Vector3.zero;
 
         //ALL RBS
-        int numOfRB = 0;
+        int numOfRb = 0;
         foreach (var item in m_JdController.bodyPartsList)
         {
-            numOfRB++;
+            numOfRb++;
             velSum += item.rb.velocity;
         }
 
-        avgVel = velSum / numOfRB;
+        avgVel = velSum / numOfRb;
         return avgVel;
     }
 

Project/Assets/ML-Agents/Examples/FoodCollector/Scripts/FoodCollectorAgent.cs

@@ -1,4 +1,3 @@
-using System;
 using UnityEngine;
 using Unity.MLAgents;
 using Unity.MLAgents.Actuators;
@@ -106,7 +105,7 @@ public void MoveAgent(ActionBuffers actionBuffers)
             dirToGo += transform.right * right;
             rotateDir = -transform.up * rotate;
 
-            var shootCommand = (int)discreteActions[0] > 0;
+            var shootCommand = discreteActions[0] > 0;
             if (shootCommand)
             {
                 m_Shoot = true;

Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3Agent.cs

@@ -166,7 +166,7 @@ void AnimatedUpdate()
 
             m_TimeUntilMove = MoveTime;
 
-            var nextState = State.Invalid;
+            State nextState;
             switch (m_CurrentState)
             {
                 case State.FindMatches:
@@ -214,7 +214,7 @@ void AnimatedUpdate()
 
         bool HasValidMoves()
         {
-            foreach (var move in Board.ValidMoves())
+            foreach (var unused in Board.ValidMoves())
             {
                 return true;
             }

Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3Drawer.cs

@@ -1,6 +1,5 @@
 using System.Collections.Generic;
 using UnityEngine;
-using Unity.MLAgents.Extensions.Match3;
 
 namespace Unity.MLAgentsExamples
 {

Project/Assets/ML-Agents/Examples/Match3/Scripts/Match3TileSelector.cs

@@ -1,4 +1,3 @@
-using System.Collections;
 using System.Collections.Generic;
 using UnityEngine;
 
@@ -35,7 +34,6 @@ public void SetActiveTile(int typeIndex, int matIndex)
         {
             AllTilesOff();
             emptyTile.SetActive(true);
-            return;
         }
         else
         {

Project/Assets/ML-Agents/Examples/Soccer/Scripts/AgentSoccer.cs

@@ -1,4 +1,3 @@
-using System;
 using UnityEngine;
 using Unity.MLAgents;
 using Unity.MLAgents.Actuators;

Project/Assets/ML-Agents/Examples/Template/Scripts/TemplateAgent.cs

@@ -1,4 +1,3 @@
-using UnityEngine;
 using Unity.MLAgents;
 using Unity.MLAgents.Actuators;
 using Unity.MLAgents.Sensors;

Project/Assets/ML-Agents/Examples/Walker/Scripts/WalkerAgent.cs

@@ -24,7 +24,7 @@ public float MTargetWalkingSpeed // property
     const float m_maxWalkingSpeed = 10; //The max walking speed
 
     //Should the agent sample a new goal velocity each episode?
-    //If true, walkSpeed will be randomly set between zero and m_maxWalkingSpeed in OnEpisodeBegin() 
+    //If true, walkSpeed will be randomly set between zero and m_maxWalkingSpeed in OnEpisodeBegin()
     //If false, the goal velocity will be walkingSpeed
     public bool randomizeWalkSpeedEachEpisode;
 
@@ -146,7 +146,7 @@ public override void CollectObservations(VectorSensor sensor)
         //ragdoll's avg vel
         var avgVel = GetAvgVelocity();
 
-        //current ragdoll velocity. normalized 
+        //current ragdoll velocity. normalized
         sensor.AddObservation(Vector3.Distance(velGoal, avgVel));
         //avg body vel relative to cube
         sensor.AddObservation(m_OrientationCube.transform.InverseTransformDirection(avgVel));
@@ -264,14 +264,14 @@ Vector3 GetAvgVelocity()
         Vector3 avgVel = Vector3.zero;
 
         //ALL RBS
-        int numOfRB = 0;
+        int numOfRb = 0;
         foreach (var item in m_JdController.bodyPartsList)
         {
-            numOfRB++;
+            numOfRb++;
             velSum += item.rb.velocity;
         }
 
-        avgVel = velSum / numOfRB;
+        avgVel = velSum / numOfRb;
         return avgVel;
     }