Improve scanner credential safety gates#2115
Open
shensz2017 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1752.
Adds credential safety and lockout evidence gates to
scanner-tuningso credentialed scan coverage is not treated as clean when authentication fails, local checks are skipped, scanner accounts drift, lockout thresholds are exceeded, or Vault/PAM evidence is missing.What changed
scanner-tuningto1.0.1.Credential Safety and Lockout Evidence Gateafter authenticated scanning configuration.SCAN-CRED-01throughSCAN-CRED-08finding triggers.Credential Safety Evidencetable to the report template.skills/vuln-management/scanner-tuning/tests/.Validation
git diff --cached --check.github/workflows/lint-skills.ymlindex.yamlfile-existence check matching.github/workflows/validate-index.yml.github/workflows/injection-scan.ymlSCAN-CRED-*,Credential Safety and Lockout Evidence Gate,Credential Safety Evidence, Failed Authentication, Not Evaluable, Vault/PAM, lockout alignment, authentication denominator, and privilege drift reviewNote: YAML parser validation was attempted, but a local YAML parser was not available (
yamlNode module unavailable; Ruby and PyYAML also unavailable in this environment).Bounty
Requesting Improver - Moderate ($100). Preferred payment method: GitHub Sponsors if accepted, otherwise private payment details can be provided after acceptance.