Add GCP IAM conditions fixtures#2113
Open
DENGXUELIN wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1727
Summary
Adds fixture-backed IAM Conditions and time-bound access evidence handling to
gcp-review.Changes include:
GCP-IAM-COND-01throughGCP-IAM-COND-08for binding inventory, CEL condition evidence, enforceable expiry, scoped conditions, unsupported basic/public grants, break-glass governance, drift/expiry monitoring, and evidence confidencegcloud/Cloud Asset evidence commands, review checks, and unsupported basic/public grant guidanceWhy
The existing #1728 and #1729 PRs add useful skill/checklist guidance, but neither adds local regression fixtures. This PR keeps the fix skill-local and adds concrete benign and vulnerable Terraform examples so future reviews distinguish deployed IAM Conditions from ticket-only or unsupported conditional-access claims.
Validation
git diff --check origin/main...HEADGCP-IAM-COND-01throughGCP-IAM-COND-08,IAM Conditions and Time-Bound Access Evidence,request.time < timestamp,allAuthenticatedUsers,roles/owner,roles/editor,roles/viewer,configuring-temporary-access, andversion: "1.0.1"git merge-tree --write-tree origin/main HEADBounty
I have read and agree to the CONTRIBUTING.md bounty terms. Requested Improver Moderate tier if accepted.