Improve dependency lockfile integrity gates#2108
Open
shensz2017 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #384.
Adds lockfile artifact integrity and registry provenance evidence gates to
dependency-scanningso reviewers can distinguish normal lockfile metadata from non-CVE supply-chain risks such as missing integrity evidence, unexpected artifact hosts, mutable source refs, install-script execution, signature/provenance gaps, and SBOM/lockfile drift.What changed
dependency-scanningto1.0.1.Lockfile Artifact Integrity and Registry Provenanceguidance before CVE/license triage.DEP-LOCK-01throughDEP-LOCK-08finding triggers covering:resolvedmetadata,registry.npmjs.org, legitimate install scripts, unsupported signature/provenance evidence, and local workspace links.skills/appsec/dependency-scanning/tests/.Validation
git diff --cached --check.github/workflows/lint-skills.ymlindex.yamlfile-existence check matching.github/workflows/validate-index.yml.github/workflows/injection-scan.ymlDEP-LOCK-*,package-lock.json,npm-shrinkwrap.json,resolved,integrity,hasInstallScript,npm audit signatures, signature/provenance output, and metadata mismatch coverageDEP-LOCK-*expectations and benign verified artifact-source evidenceNote: YAML parser validation was attempted, but a local YAML parser was not available (
yamlNode module unavailable; Ruby and PyYAML also unavailable in this environment).References
Bounty
Requesting Improver - Moderate ($100). Preferred payment method: GitHub Sponsors if accepted, otherwise private payment details can be provided after acceptance.