Merge pull request #391 from UiPath/fix/ui-suggest-remove-empty-space

fix(suggest): reduce height of ui-suggest when no results found

Author: dan-mirescu

projects/angular/components/ui-suggest/src/ui-suggest.component.html

@@ -301,7 +301,7 @@
             </ng-container>
 
             <mat-list-item *ngIf="loading$ | async"
-                           [style.height.px]="itemSize">
+                           [style.height.px]="baseSize">
                 <mat-progress-spinner color="primary"
                                       mode="indeterminate"
                                       diameter="20"

projects/angular/components/ui-suggest/src/ui-suggest.component.ts

@@ -439,13 +439,14 @@ export class UiSuggestComponent extends UiSuggestMatFormFieldDirective
             return this._height$.value;
         }
 
-        const actualCount = Math.max(
-            this.renderItems.filter(Boolean).length + (this.enableCustomValue ?
-                (Number(this.isCustomValueVisible)) : (this.headerItems!.length)),
-            1,
-        );
-        const displayedCount = Math.min(this.displayCount, actualCount);
+        const actualCount = this.renderItems.filter(Boolean).length + (this.enableCustomValue ?
+            (Number(this.isCustomValueVisible)) : (this.headerItems!.length));
+
+        if (actualCount === 0) {
+            return this.baseSize + Number(!!this.headerItems!.length);
+        }
 
+        const displayedCount = Math.min(this.displayCount, Math.max(actualCount, 1));
         return this.itemSize * displayedCount + Number(!!this.headerItems!.length);
     }
 

projects/angular/components/ui-suggest/src/ui-suggest.mat-form-field.ts

@@ -131,6 +131,10 @@ export abstract class UiSuggestMatFormFieldDirective implements
     get itemSize() {
         if (this.customItemSize) { return this.customItemSize; }
 
+        return this.baseSize;
+    }
+
+    get baseSize() {
         return this.isFormControl ? 32 : 40;
     }