fix: ensure embedded PostgreSQL is cleaned up on crash or forced termination (Fix JabRef#12844)

* style changes in PostgreProcessCleaner, Launcher

Author: UdayHE

src/main/java/org/jabref/Launcher.java

@@ -10,9 +10,10 @@
 import org.jabref.logic.UiCommand;
 import org.jabref.logic.preferences.CliPreferences;
 import org.jabref.logic.search.PostgreServer;
-import org.jabref.logic.search.PostgreProcessCleaner;
 import org.jabref.logic.util.HeadlessExecutorService;
 import org.jabref.migrations.PreferencesMigrations;
+import org.jabref.logic.search.PostgreProcessCleaner;
+
 
 import com.airhacks.afterburner.injection.Injector;
 
@@ -27,7 +28,7 @@ public class Launcher {
     public static void main(String[] args) {
         JabKit.initLogging(args);
 
-        //Clean up old Postgres instance if needed
+        // Clean up old Postgres instance if needed
         PostgreProcessCleaner.getInstance().checkAndCleanupOldInstance();
 
         // Initialize preferences
@@ -46,7 +47,7 @@ public static void main(String[] args) {
         PostgreServer postgreServer = new PostgreServer();
         Injector.setModelOrService(PostgreServer.class, postgreServer);
 
-        //Register shutdown hook
+        // Register shutdown hook
         Runtime.getRuntime().addShutdownHook(new Thread(postgreServer::shutdown));
 
         JabRefGUI.setup(uiCommands, preferences, fileUpdateMonitor);

src/main/java/org/jabref/logic/search/PostgreProcessCleaner.java

@@ -1,9 +1,5 @@
 package org.jabref.logic.search;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import java.io.BufferedReader;
 import java.io.IOException;
 import java.io.InputStreamReader;
@@ -13,6 +9,10 @@
 import java.util.Map;
 import java.util.Optional;
 
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import static org.jabref.logic.os.OS.getHostName;
 import static org.jabref.logic.search.PostgreServer.POSTGRES_METADATA_FILE;
 
@@ -27,13 +27,14 @@ public static PostgreProcessCleaner getInstance() {
     }
 
     public void checkAndCleanupOldInstance() {
-        if (!Files.exists(POSTGRES_METADATA_FILE))
+        if (!Files.exists(POSTGRES_METADATA_FILE)) {
             return;
+        }
 
         try {
             Map<String, Object> metadata = new HashMap<>(new ObjectMapper()
                     .readValue(Files.readAllBytes(POSTGRES_METADATA_FILE), HashMap.class));
-            if(!metadata.isEmpty()) {
+            if (!metadata.isEmpty()) {
                 int port = ((Number) metadata.get("postgresPort")).intValue();
                 destroyPreviousJavaProcess(metadata);
                 destroyPostgresProcess(port);
@@ -97,7 +98,6 @@ private long getPidUsingPort(int port) {
         } catch (Exception e) {
             LOGGER.warn("Failed to get PID for port {}: {}", port, e.getMessage());
         }
-
         return -1;
     }
 
@@ -128,16 +128,17 @@ private long extractPidFromOutput(String os, BufferedReader reader) throws IOExc
 
     private Long parseUnixPidFromLine(String line) {
         String[] parts = line.trim().split("\\s+");
-        if (parts.length > 1 && parts[1].matches("\\d+"))
+        if (parts.length > 1 && parts[1].matches("\\d+")) {
             return Long.parseLong(parts[1]);
+        }
         return null;
     }
 
     private Long parseWindowsPidFromLine(String line) {
         String[] parts = line.trim().split("\\s+");
-        if (parts.length >= 5 && parts[parts.length - 1].matches("\\d+"))
+        if (parts.length >= 5 && parts[parts.length - 1].matches("\\d+")) {
             return Long.parseLong(parts[parts.length - 1]);
+        }
         return null;
     }
-
 }