fixes JabRef#12844

* Fix for trag-bot comments.
* Created separate class PostgresMetadataWriter to follow SRP.

Author: UdayHE

src/main/java/org/jabref/logic/search/PostgreServer.java

@@ -1,19 +1,13 @@
 package org.jabref.logic.search;
 
 import java.io.IOException;
-import java.nio.file.Path;
 import java.sql.Connection;
 import java.sql.SQLException;
-import java.time.Instant;
-import java.time.format.DateTimeFormatter;
-import java.util.HashMap;
-import java.util.Map;
 
 import javax.sql.DataSource;
 
 import org.jabref.model.search.PostgreConstants;
 
-import com.fasterxml.jackson.databind.ObjectMapper;
 import io.zonky.test.db.postgres.embedded.EmbeddedPostgres;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -22,11 +16,6 @@
 
 public class PostgreServer {
     private static final Logger LOGGER = LoggerFactory.getLogger(PostgreServer.class);
-    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
-    private static final Path POSTGRES_METADATA_FILE = Path.of(
-            System.getProperty("java.io.tmpdir"),
-            "jabref-postgres-info-" + ProcessHandle.current().pid() + ".json"
-    );
 
     private final EmbeddedPostgres embeddedPostgres;
     private final DataSource dataSource;
@@ -38,7 +27,7 @@ public PostgreServer() {
                                                .setOutputRedirector(ProcessBuilder.Redirect.DISCARD)
                                                .start();
             LOGGER.info("Postgres server started, connection port: {}", embeddedPostgres.getPort());
-            writeMetadataToFile(embeddedPostgres.getPort());
+            PostgresMetadataWriter.write(embeddedPostgres.getPort());
         } catch (IOException e) {
             LOGGER.error("Could not start Postgres server", e);
             this.embeddedPostgres = null;
@@ -109,23 +98,4 @@ public void shutdown() {
             }
         }
     }
-
-    private void writeMetadataToFile(int port) {
-        try {
-            Map<String, Object> meta = createPostgresMetadata(port);
-            OBJECT_MAPPER.writerWithDefaultPrettyPrinter().writeValue(POSTGRES_METADATA_FILE.toFile(), meta);
-            LOGGER.info("Postgres metadata file path: {}", POSTGRES_METADATA_FILE);
-        } catch (IOException e) {
-            LOGGER.warn("Failed to write Postgres metadata file", e);
-        }
-    }
-
-    private Map<String, Object> createPostgresMetadata(int port) {
-        Map<String, Object> meta = new HashMap<>();
-        meta.put("javaPid", ProcessHandle.current().pid());
-        meta.put("postgresPort", port);
-        meta.put("startedBy", "jabref");
-        meta.put("startedAt", DateTimeFormatter.ISO_INSTANT.format(Instant.now()));
-        return meta;
-    }
 }

src/main/java/org/jabref/logic/search/PostgresMetadataWriter.java

@@ -0,0 +1,45 @@
+package org.jabref.logic.search;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.time.Instant;
+import java.time.format.DateTimeFormatter;
+import java.util.HashMap;
+import java.util.Map;
+
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class PostgresMetadataWriter {
+    private static final Logger LOGGER = LoggerFactory.getLogger(PostgresMetadataWriter.class);
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+
+    private PostgresMetadataWriter() {
+    }
+
+    public static Path getMetadataFilePath() {
+        return Path.of(System.getProperty("java.io.tmpdir"),
+                       "jabref-postgres-info-" + ProcessHandle.current().pid() + ".json");
+    }
+
+    public static void write(int port) {
+        try {
+            Map<String, Object> meta = createMetadata(port);
+            Path path = getMetadataFilePath();
+            OBJECT_MAPPER.writerWithDefaultPrettyPrinter().writeValue(path.toFile(), meta);
+            LOGGER.info("Postgres metadata file path: {}", path);
+        } catch (IOException e) {
+            LOGGER.warn("Failed to write Postgres metadata file", e);
+        }
+    }
+
+    private static Map<String, Object> createMetadata(int port) {
+        Map<String, Object> meta = new HashMap<>();
+        meta.put("javaPid", ProcessHandle.current().pid());
+        meta.put("postgresPort", port);
+        meta.put("startedBy", "jabref");
+        meta.put("startedAt", DateTimeFormatter.ISO_INSTANT.format(Instant.now()));
+        return meta;
+    }
+}