Skip to content

Commit 5366b9c

Browse files
authored
Merge pull request #292 from UMC-Closit/fix/#291-param-name-fix
fix: ํŒŒ๋ผ๋ฏธํ„ฐ ๋ช… ๋ช…์‹œ ๋ฐ ์ฐจ๋‹จ ๋ชฉ๋ก ์กฐํšŒ ์ฝ”๋“œ ์ˆ˜์ •
2 parents cdb82f2 + 3aa3feb commit 5366b9c

7 files changed

Lines changed: 22 additions & 21 deletions

File tree

โ€Žbuild.gradleโ€Ž

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,16 @@ dependencies {
6666
implementation 'com.github.ben-manes.caffeine:caffeine:3.1.8'
6767
}
6868

69+
tasks.withType(JavaCompile) {
70+
options.compilerArgs = ['-parameters']
71+
}
72+
6973
tasks.named('test') {
7074
useJUnitPlatform()
7175
systemProperty 'file.encoding', 'UTF-8'
7276
}
7377

78+
7479
jar {
7580
enabled = false
7681
}

โ€Žsrc/main/java/UMC_7th/Closit/domain/user/controller/UserController.javaโ€Ž

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,10 @@ public ApiResponse<String> unblockUser(@RequestBody UserRequestDTO.BlockUserDTO
9898
@Operation(summary = "์‚ฌ์šฉ์ž ์ฐจ๋‹จ ๋ชฉ๋ก ์กฐํšŒ", description = "ํŠน์ • ์‚ฌ์šฉ์ž์˜ ์ฐจ๋‹จ ๋ชฉ๋ก์„ ์กฐํšŒํ•ฉ๋‹ˆ๋‹ค.")
9999
@GetMapping("/blocks")
100100
public ApiResponse<UserResponseDTO.UserBlockListDTO> getBlockedUserList(
101-
@RequestParam(defaultValue = "0") int page,
102-
@RequestParam(defaultValue = "10") int size) {
101+
@RequestParam(name = "page", defaultValue = "0") int page,
102+
@RequestParam(name = "size", defaultValue = "10") int size) {
103103

104-
Slice<User> blockedUserSlice = userQueryService.getBlockedUserList(PageRequest.of(page, size));
104+
Slice<String> blockedUserSlice = userQueryService.getBlockedUserList(PageRequest.of(page, size));
105105
return ApiResponse.onSuccess(UserConverter.toUserBlockListDTO(blockedUserSlice));
106106
}
107107

@@ -127,8 +127,8 @@ public ApiResponse<UserResponseDTO.IsBlockedDTO> isBlockedBy(@RequestParam("clos
127127
@GetMapping("/{closit_id}/followers")
128128
public ApiResponse<UserResponseDTO.UserFollowerSliceDTO> getUserFollowers (
129129
@PathVariable("closit_id") String closit_id,
130-
@RequestParam(defaultValue = "0") int page,
131-
@RequestParam(defaultValue = "10") int size) {
130+
@RequestParam(name = "page", defaultValue = "0") int page,
131+
@RequestParam(name = "size", defaultValue = "10") int size) {
132132

133133
Slice<User> followerSlice = userQueryService.getFollowerList(closit_id, PageRequest.of(page, size));
134134
return ApiResponse.onSuccess(UserConverter.toUserFollowerSliceDTO(followerSlice));
@@ -150,8 +150,8 @@ public ApiResponse<UserResponseDTO.UserFollowerSliceDTO> getUserFollowers (
150150
@GetMapping("/{closit_id}/following")
151151
public ApiResponse<UserResponseDTO.UserFollowingSliceDTO> getUserFollowing(
152152
@PathVariable("closit_id") String closit_id,
153-
@RequestParam(defaultValue = "0") int page,
154-
@RequestParam(defaultValue = "10") int size) {
153+
@RequestParam(name = "page", defaultValue = "0") int page,
154+
@RequestParam(name = "size", defaultValue = "10") int size) {
155155

156156
Slice<User> followingSlice = userQueryService.getFollowingList(closit_id, PageRequest.of(page, size));
157157
return ApiResponse.onSuccess(UserConverter.toUserFollowingSliceDTO(followingSlice));
@@ -173,8 +173,8 @@ public ApiResponse<UserResponseDTO.UserFollowingSliceDTO> getUserFollowing(
173173
@GetMapping("/{closit_id}/highlights")
174174
public ApiResponse<UserResponseDTO.UserHighlightSliceDTO> getUserHighlights(
175175
@PathVariable("closit_id") String closit_id,
176-
@RequestParam(defaultValue = "0") int page,
177-
@RequestParam(defaultValue = "10") int size) {
176+
@RequestParam(name = "page", defaultValue = "0") int page,
177+
@RequestParam(name = "size", defaultValue = "10") int size) {
178178

179179
Slice<Highlight> highlightSlice = userQueryService.getHighlightList(closit_id, PageRequest.of(page, size));
180180

@@ -256,8 +256,8 @@ public ApiResponse<String> deactivateUser(@RequestBody @Valid UserRequestDTO.Dea
256256
@GetMapping("/search")
257257
public ApiResponse<UserResponseDTO.UserSearchListDTO> searchUsers(
258258
@RequestParam(name = "keyword") @Size(min = 1, max = 50, message = "๊ฒ€์ƒ‰์–ด๋Š” 1์ž ์ด์ƒ 50์ž ์ดํ•˜์—ฌ์•ผ ํ•ฉ๋‹ˆ๋‹ค") String keyword,
259-
@RequestParam(defaultValue = "0") int page,
260-
@RequestParam(defaultValue = "10") int size
259+
@RequestParam(name = "page", defaultValue = "0") int page,
260+
@RequestParam(name = "size", defaultValue = "10") int size
261261
) {
262262
Slice<User> userSlice = userQueryService.searchUsersByClositId(keyword, PageRequest.of(page, size));
263263
return ApiResponse.onSuccess(UserConverter.toUserSearchListDTO(userSlice));

โ€Žsrc/main/java/UMC_7th/Closit/domain/user/converter/UserConverter.javaโ€Ž

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,11 @@ public static UserResponseDTO.UserBlockResponseDTO toUserBlockResponseDTO (Block
109109
.build();
110110
}
111111

112-
public static UserResponseDTO.UserBlockListDTO toUserBlockListDTO(Slice<User> blockedUserSlice) {
112+
public static UserResponseDTO.UserBlockListDTO toUserBlockListDTO(Slice<String> blockedUserSlice) {
113113
List<UserResponseDTO.UserBlockDTO> blockedUserList =
114114
blockedUserSlice.getContent().stream()
115-
.map(user -> UserResponseDTO.UserBlockDTO.builder()
116-
.clositId(user.getClositId())
117-
.name(user.getName())
118-
.profileImage(user.getProfileImage())
115+
.map(clositId -> UserResponseDTO.UserBlockDTO.builder()
116+
.clositId(clositId)
119117
.build())
120118
.collect(Collectors.toList());
121119

โ€Žsrc/main/java/UMC_7th/Closit/domain/user/dto/UserResponseDTO.javaโ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,8 +183,6 @@ public static class UserBlockListDTO {
183183
@AllArgsConstructor
184184
public static class UserBlockDTO {
185185
private String clositId;
186-
private String name;
187-
private String profileImage;
188186
}
189187

190188
@Builder

โ€Žsrc/main/java/UMC_7th/Closit/domain/user/repository/BlockRepository.javaโ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,6 @@ public interface BlockRepository extends JpaRepository<Block, Long> {
1616
Optional<Block> findByBlockerIdAndBlockedId (String blockerId, String blockedId);
1717

1818
@Query("SELECT b.blockedId FROM Block b WHERE b.blockerId = :blockerId")
19-
Slice<User> findBlockedUsersByBlocker(@Param("blockerId") String blockerId, Pageable pageable);
19+
Slice<String> findBlockedUsersByBlocker(@Param("blockerId") String blockerId, Pageable pageable);
2020

2121
}

โ€Žsrc/main/java/UMC_7th/Closit/domain/user/service/UserQueryService.javaโ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public interface UserQueryService {
2222

2323
Slice<Post> getRecentPostList(String clositId, Integer page); // ํŠน์ • ์‚ฌ์šฉ์ž์˜ ์ตœ๊ทผ ๊ฒŒ์‹œ๊ธ€ ์กฐํšŒ
2424

25-
Slice<User> getBlockedUserList(Pageable pageable);
25+
Slice<String> getBlockedUserList(Pageable pageable);
2626

2727
UserResponseDTO.IsBlockedDTO isBlockedBy(String targetClositId);
2828

โ€Žsrc/main/java/UMC_7th/Closit/domain/user/service/UserQueryServiceImpl.javaโ€Ž

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public Slice<Post> getRecentPostList(String clositId, Integer page) { // ํŠน์ •
9696
}
9797

9898
@Override
99-
public Slice<User> getBlockedUserList(Pageable pageable) {
99+
public Slice<String> getBlockedUserList(Pageable pageable) {
100100
User currentUser = securityUtil.getCurrentUser();
101101
return userBlockRepository.findBlockedUsersByBlocker(currentUser.getClositId(), pageable);
102102
}

0 commit comments

Comments
ย (0)